rc93 discussion (Feb 2021?)

[AkihiroSuda]

I propose releasing rc93 in the next month December.

@opencontainers/runc-maintainers Please add items you want to get merged in rc93 to https://github.com/opencontainers/runc/milestone/10

Notable changes since rc92: v1.0.0-rc92...master

• support Cgroups.Resources.Unified without v1 conversion b006f4a
• support CAP_PERFMON, CAP_BPF, and CAP_CHECKPOINT_RESTORE 6dfbe9b
• support Go 1.15 4c71a68 , 1.16(rc1) b1195b7
• Move cgroup v2 out of experimental 3f2f06d
• Removal of "apparmor" and "selinux" build tags. These features are now always compiled. 552a1c7 cb26930
• new blkio and cpuset stats 990a6c5 ab27e12
• seccomp: prepend -ENOSYS stub to all filters 7a8d716
• Lots of refactoring

[AkihiroSuda]

@cyphar WDYT?

[cyphar]

I don't have any outstanding things I'd like to get into rc93. I just merged #2634 so I guess the only thing left is whether we want to mark cgroupv2 as non-experimental. As far as I can tell, we still need to sort out #2602 / #2603 (so that "unified" works properly under systemd). I don't know how much remaining work there is to do to fix that.

All of that being said, I would hope we can do a 1.0 release a few weeks after rc93 (assuming nothing major happens). So any features we don't get in to rc93 will need to wait a month or so.

[dims]

I would love to get rc93 into containerd and then kubernetes when it's ready. Early November looks great for k8s at least as 1.20 code freeze is Nov 12-ish at the moment.

[kolyshkin]

(so that "unified" works properly under systemd)

I'm not sure this is super critical to have for rc93, but my WIP attempt is in #2669, will try to add more this week

[AkihiroSuda]

Do we want to wait for #2599 (reduces reading mountinfo), or shall we release rc93 from the current master?

[cyphar]

I'll review #2599 now, we can merge it now (assuming it's all good) and then I'll send out the vote for the release.

[AkihiroSuda]

This is likely to be early next month, probably.

[cyphar]

We probably want to hotfix #2151 in this release so Docker can at least check that our hotfix won't break them.

[AkihiroSuda]

@cyphar What do we need for #2151? How long will it take?

[stokito]

It would be nice to perform at least intermediate release because it's so many changes that github even can't show diff between master and last release tag.

[ehashman]

Hi folks,

Any updates on this? It looks like some of the fixes since the previous release will be needed to address kubernetes/kubernetes#97497

cc @AkihiroSuda @cyphar

[AkihiroSuda]

@ehashman I think the current blocker is whether to include this to rc93 or not: #2151

[kylecarbs]

@AkihiroSuda @cyphar any ideas on rc93 release date?

#2522 is quite critical for us to use runc.

[AkihiroSuda]

Soon after reaching the decision on #2750 .
I personally expect it to land on Feb, but not certainty.

[cyphar]

Yeah #2750 is the final blocker imho.

[kolyshkin]

I have added #2753 / #2774 to the rc93 milestone as it's a regression that is seen in production and the fix makes sense.

[kolyshkin]

I suggest we merge #2599 #2769 #2774 and bake a release.

[cyphar]

Yup, I agree. I've LGTM'd all three and only #2774 is left to merge. I will cook up a release as soon as it is merged.

[cyphar]

That's all of the PRs merged. Tip is still failing lints, but as discussed we can just move on with a release. I'm preparing the release now.

[dims]

w00t! thanks @cyphar