Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with golang 1.16-rc1 #2769

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jan 26, 2021

Using beta version of go as per actions/setup-go#92

[v2: move from beta1 to rc1]

Includes #2660 to fix #2675.

@kolyshkin kolyshkin force-pushed the ci-go1.16 branch 4 times, most recently from e563934 to 3b1caa2 Compare January 26, 2021 21:05
@kolyshkin kolyshkin added this to the 1.0.0-rc93 milestone Jan 27, 2021
AkihiroSuda
AkihiroSuda previously approved these changes Jan 27, 2021
go 1.16 has GO111MODULE=on by default, and since runtime-spec/schema
does not come with go.mod, it complains:

> runtime-spec/schema/validate.go:10:2: no required module provides package github.com/xeipuuv/gojsonschema: working directory is not part of a module

Use GO111MODULE=auto as a workaround.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Courtesy of actions/setup-go#92

[v2: update from beta1 to rc1]

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin changed the title ci: test with golang 1.16-beta1 ci: test with golang 1.16-rc1 Jan 28, 2021
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it would be nice if we added 1.x and tip to our tests so we don't need to keep manually updating the GHA.

@cyphar cyphar closed this in a4f2b2b Feb 1, 2021
@cyphar cyphar merged commit a4f2b2b into opencontainers:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants