libct: suppress bogus "unable to terminate" warnings #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on a test case for [1], I got the following warning: > level=warning msg="unable to terminate initProcess" error="exit status 1" Obviously, the warning is bogus since the initProcess is terminated. This is happening because terminate() can return errors from either Kill() or Wait(), and the latter returns an error if the process has not finished successfully (i.e. exit status is not 0 or it was killed). Check for a particular error type and filter out those errors. [1] opencontainers#2683 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This is a new variable added by go 1.16 so we'll have to wait until 1.16 is minimally supported version, thus TODO for now. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
rebased (for new CI) |
AkihiroSuda
approved these changes
Jan 14, 2021
|
@mrunalp ptal |
|
Just saw it again and it took me some time to find out I already had it fixed:
|
mrunalp
reviewed
Jan 22, 2021
| @@ -2067,9 +2067,20 @@ func ignoreTerminateErrors(err error) error { | |||
| if err == nil { | |||
| return nil | |||
| } | |||
| // terminate() might return an error from ether Kill or Wait. | |||
mrunalp
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a test case for #2715, I got the following warning:
Obviously, the warning is bogus since the initProcess is terminated.
This is happening because terminate() can return errors from either
Kill() or Wait(), and the latter returns an error if the process has
not finished successfully (i.e. exit status is not 0 or it was killed).
Check for a particular error type and filter out those errors.