libct/specconv: checkPropertyName speedup #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 029b73c replaced a regular expression with code checking the characters. Despite what the comment said about ASCII, the check was performed rune by rune, not byte by byte. Note the check was still correct, basically comparing int32's, but the byte by byte way is a tad faster and more straightforward. The change also fixes the issue of a misleading comment. Benchmark before/after shows a modest improvement: name old time/op new time/op delta CheckPropertyName-4 164ns ± 2% 123ns ± 2% -24.73% (p=0.029 n=4+4) name old alloc/op new alloc/op delta CheckPropertyName-4 96.0B ± 0% 64.0B ± 0% -33.33% (p=0.029 n=4+4) name old allocs/op new allocs/op delta CheckPropertyName-4 6.00 ± 0% 4.00 ± 0% -33.33% (p=0.029 n=4+4) Fixes: 029b73c Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
changed the title
|
@opencontainers/runc-maintainers PTAL (this is very easy to review) |
AkihiroSuda
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
Mostly done because the comment was misleading, not in line with what the code did.
Fix the code, so now the comment is fine.