Commits on Feb 1, 2022

1. libct/specconv: test nits …

   Commit 643f8a2 renamed isValidName to checkPropertyName, but fell
   short of renaming its test and benchmark. Fix that.
   
   Fixes: 643f8a2
   Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

   

   kolyshkin committed Feb 1, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for d37a972
   • Browse repository at this point

   Copy the full SHA

   d37a972 View commit details

   Browse the repository at this point in the history

2. libct/specconv: improve checkPropertyName …

   Commit 029b73c replaced a regular expression with code checking the
   characters. Despite what the comment said about ASCII, the check was
   performed rune by rune, not byte by byte.
   
   Note the check was still correct, basically comparing int32's, but the
   byte by byte way is a tad faster and more straightforward. The change
   also fixes the issue of a misleading comment.
   
   Benchmark before/after shows a modest improvement:
   
   name                 old time/op    new time/op    delta
   CheckPropertyName-4     164ns ± 2%     123ns ± 2%  -24.73%  (p=0.029 n=4+4)
   
   name                 old alloc/op   new alloc/op   delta
   CheckPropertyName-4     96.0B ± 0%     64.0B ± 0%  -33.33%  (p=0.029 n=4+4)
   
   name                 old allocs/op  new allocs/op  delta
   CheckPropertyName-4      6.00 ± 0%      4.00 ± 0%  -33.33%  (p=0.029 n=4+4)
   
   Fixes: 029b73c
   Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

   

   kolyshkin committed Feb 1, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 376c988
   • Browse repository at this point

   Copy the full SHA

   376c988 View commit details

   Browse the repository at this point in the history