-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec version to runC version cli #405
Conversation
Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
On Tue, Nov 17, 2015 at 02:15:59PM -0800, Marcos Nils wrote:
I'm not sure what the plan is for backwards compatibility, but if |
@wking if the specs are pulled from the specs repo, how could supporting 1.x and 2.x would exactly work?. Because that will involve having two different versions of the spec in the runc repository? My thought that the idea was always to support only one major version of the spec, but I might be confused. |
On Tue, Nov 17, 2015 at 02:35:46PM -0800, Marcos Nils wrote:
I'm not sure what the plan is for that. There's no fundamental reason |
One way to support would be by maintaining different branches but we still need to figure that out. |
+1 LGTM especially given that #410 just brought the |
LGTM |
LGTM |
Add spec version to runC version cli
This PR prints specs versions when
runc --version
is used.Sample:
Signed-off-by: Marcos Lilljedahl marcosnils@gmail.com