Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec version to runC version cli #405

Merged
merged 1 commit into from
Jan 22, 2016

Conversation

marcosnils
Copy link
Contributor

This PR prints specs versions when runc --version is used.

Sample:

marcos@XPS:~$ ./runc --version
runc version 0.3
spec version 0.2.0

Signed-off-by: Marcos Lilljedahl marcosnils@gmail.com

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
@wking
Copy link
Contributor

wking commented Nov 17, 2015

On Tue, Nov 17, 2015 at 02:15:59PM -0800, Marcos Nils wrote:

This PR prints specs versions when runc --version is used.

I'm not sure what the plan is for backwards compatibility, but if
there is an intention to support 1.x and 2.x specs with the same runC
implementation, we may want to extend this to support multiple spec
versions (e.g. the latest 1.x and 2.x spec versions supported by that
runtime). On the other hand, a 2.x spec release is probably a ways
off, and runC currently only supports a single spec release (modulo
SemVer?) anyway, so maybe this UI is good enough for now?

@marcosnils
Copy link
Contributor Author

@wking if the specs are pulled from the specs repo, how could supporting 1.x and 2.x would exactly work?. Because that will involve having two different versions of the spec in the runc repository?

My thought that the idea was always to support only one major version of the spec, but I might be confused.

@wking
Copy link
Contributor

wking commented Nov 17, 2015

On Tue, Nov 17, 2015 at 02:35:46PM -0800, Marcos Nils wrote:

@wking if the specs are pulled from the specs repo, how could
supporting 1.x and 2.x would exactly work?. Because that will
involve having two different versions of the spec in the runc
repository?

I'm not sure what the plan is for that. There's no fundamental reason
you can't support two major versions of the spec with a single
runtime, but it might not be something that the runC folks are
interested in. I'm just bringing it up, because if they are
interested in it, this is a place where that would matter.

@mrunalp
Copy link
Contributor

mrunalp commented Nov 18, 2015

One way to support would be by maintaining different branches but we still need to figure that out.

@tianon
Copy link
Member

tianon commented Nov 20, 2015

+1 LGTM especially given that #410 just brought the version constant in line with the tags here, so the runc version is more meaningful again 😄

@mrunalp
Copy link
Contributor

mrunalp commented Nov 24, 2015

LGTM

@crosbymichael
Copy link
Member

LGTM

crosbymichael added a commit that referenced this pull request Jan 22, 2016
Add spec version to runC version cli
@crosbymichael crosbymichael merged commit 59f3066 into opencontainers:master Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants