Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bash for get-stage3.sh #5

Closed
wants to merge 1 commit into from
Closed

Conversation

hqhq
Copy link
Contributor

@hqhq hqhq commented Jan 21, 2016

I got the following error with make rootfs.tar.gz:
./get-stage3.sh: 43: ./get-stage3.sh: Bad substitution

Change to bash fixed it.

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

I got the following error with `make rootfs.tar.gz`:
./get-stage3.sh: 43: ./get-stage3.sh: Bad substitution

Change to bash fixed it.

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@wking
Copy link
Contributor

wking commented Jan 21, 2016

On Thu, Jan 21, 2016 at 12:05:08AM -0800, Qiang Huang wrote:

I got the following error with make rootfs.tar.gz:
./get-stage3.sh: 43: ./get-stage3.sh: Bad substitution

Change to bash fixed it.

Ah, my bad. I think we can do:

CURRENT="${FILE/${DATE}/current}"

without leaving POSIX though (with ‘sed’ as a last resort). I'll try
to work up a PR.

@mrunalp
Copy link
Contributor

mrunalp commented Jan 21, 2016

Closing in favor of #8 @hqhq please retry and report if any issues. Thanks!

@mrunalp mrunalp closed this Jan 21, 2016
@hqhq hqhq deleted the hq_use_bash branch January 22, 2016 01:24
wking pushed a commit to wking/ocitools-v2 that referenced this pull request Nov 17, 2016
MAINTAINERS_GUIDE: Remove trailing whitespace
fmuyassarov pushed a commit to fmuyassarov/runtime-tools that referenced this pull request May 4, 2023
test/failing: Wrap failing tests in another harness
fmuyassarov pushed a commit to fmuyassarov/runtime-tools that referenced this pull request May 6, 2023
test/failing: Wrap failing tests in another harness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants