get-stage3.sh: Replace non-POSIX ${FILE/${DATE}/current} with sed
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
${parameter/pattern/string} isn't in POSIX 2013 [1], which leads to:
43: ./get-stage3.sh: Bad substitution
when folks run a strictly-POSIX shell. Replace it with command
substitution [2] invoking echo [3] and sed [4].
[1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02
[2]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_03
[3]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html
[4]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html
Reported-by: Qiang Huang <h.huangqiang@huawei.com>
Signed-off-by: W. Trevor King <wking@tremily.us>
|
Thanks! LGTM. |
mrunalp
pushed a commit
that referenced
this pull request
Jan 21, 2016
get-stage3.sh: Replace non-POSIX `${FILE/${DATE}/current}` with sed
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Nov 17, 2016
CONTRIBUTING: Allow collaborative pull requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${parameter/pattern/string}isn't in POSIX 2013, which leads to:when folks run a strictly-POSIX shell. Replace it with command
substitution invoking echo and sed.
An alternative to #5.