Fix visualization and default model for text detection PP-OCR #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WanliZhong Please take a look at this PR. |
WanliZhong
reviewed
Feb 28, 2024
| imshow(kWinName, originalImage); | ||
| waitKey(0); |
There was a problem hiding this comment.
Line 130 has
while (waitKey(1) < 0)So I think we don‘t need to add waitKey(0)?
There was a problem hiding this comment.
while (waitKey(1) < 0) - I believe this has a timeout of 1 ms before continuing the loop.
It then attempts to go into
cap >> originalImage;
if (originalImage.empty())
{
if (parser.has("input"))
{
cout << "Frame is empty" << endl;
break;
}
else
continue;
}
and reaches cout << "Frame is empty" << endl;, breaking the loop and ending the program. On the otherhand, waitKey(0) waits indefinitely, allowing the user to keep the processed image up for viewing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor PR to correct the default model path and address issues with visualization. The issue was partially discussed in #135 (comment).