Validator review code change #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i) Added translator code ii)Added transmission code iii)Added test folder iv)Added mapping files
ii)Added code for error handling in results_connector
i)Added code for url and end point ii) Corrected configuration attributes in config file iii) Added a function to append default time range if not present in input STIX pattern
hostname added for pytest
Updated unittest transmission file
mdazam1942
suggested changes
Nov 19, 2021
Codecov Report
@@ Coverage Diff @@
## develop #739 +/- ##
========================================
Coverage 63.29% 63.29%
========================================
Files 425 425
Lines 36817 36817
========================================
Hits 23304 23304
Misses 13513 13513
Continue to review full report at Codecov.
|
Deleting .idea directory
|
@mdazam1942 , @delliott90 |
mdazam1942
suggested changes
Nov 29, 2021
.gitignore
Outdated
| @@ -78,3 +78,5 @@ virtualenv/ | |||
| *.sqlite | |||
| deployment/ibm_cloud_pak_for_security/backup_* | |||
| deployment/ibm_cloud_pak_for_security/bundle | |||
| .idea | |||
| .idea/ | |||
There was a problem hiding this comment.
what is .idea? don't think you should make changes in .gitignore file
|
@mdazam1942 , @delliott90 |
mdazam1942
approved these changes
Nov 30, 2021
delliott90
pushed a commit
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code change on validator review comments