Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator review code change #739

Merged
merged 37 commits into from
Nov 30, 2021
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
e4e5998
Added connector code for Proofpoint
JyotiWhcl Oct 5, 2021
ae43a6c
i) Updated code for first code review comments
JyotiWhcl Oct 8, 2021
224625b
Updated code for second code review comments
JyotiWhcl Oct 12, 2021
79f456d
Merge branch 'develop' into develop
mdazam1942 Oct 12, 2021
642d920
Updated code for code review comments - code optimization
JyotiWhcl Oct 19, 2021
cf42911
Merge remote-tracking branch 'origin/develop' into develop
JyotiWhcl Oct 19, 2021
f40212b
Updated code for unit tests in tests folder
JyotiWhcl Oct 19, 2021
539a3f7
Merge branch 'develop' into develop
mdazam1942 Oct 19, 2021
77a96b9
Added README.md for Proofpoint module
JyotiWhcl Oct 20, 2021
905aa33
Merge remote-tracking branch 'origin/develop' into develop
JyotiWhcl Oct 20, 2021
c212bff
Updated changes for validator errors
JyotiWhcl Oct 22, 2021
cb3a2d9
Updated changes for validator errors and README
JyotiWhcl Oct 25, 2021
a03ab96
Updated changes for transmission module unit tests
JyotiWhcl Oct 25, 2021
472fdfa
Code changes after pytest run on unittests files
JyotiWhcl Oct 25, 2021
080c5df
Line correction
JyotiWhcl Oct 25, 2021
851cfa9
Removed principal and secret from unittest file
JyotiWhcl Oct 25, 2021
85ed5f2
decode error resolved
JyotiWhcl Oct 26, 2021
e37008f
decode error resolved
JyotiWhcl Oct 26, 2021
5c3255d
Separated transmission test module
JyotiWhcl Oct 26, 2021
80c9805
Removed credentials
JyotiWhcl Oct 26, 2021
adf400d
Added 'body' field
JyotiWhcl Oct 27, 2021
8e60a6c
Added 'body' field
JyotiWhcl Oct 27, 2021
be8ecd0
Merge branch 'develop' into develop
mdazam1942 Oct 27, 2021
00c80ad
Updated code for data type of offset and length
JyotiWhcl Nov 18, 2021
f97fec4
Updated code for data type of offset and length
JyotiWhcl Nov 18, 2021
3a440a1
Updated code for data type of offset and length
JyotiWhcl Nov 19, 2021
897a910
Revert "Updated code for data type of offset and length"
JyotiWhcl Nov 19, 2021
ca9282c
Merge remote-tracking branch 'origin/develop' into develop
JyotiWhcl Nov 19, 2021
98f1b73
Revert "Revert "Updated code for data type of offset and length""
JyotiWhcl Nov 19, 2021
8cbd5e0
Revert "Revert "Revert "Updated code for data type of offset and leng…
JyotiWhcl Nov 19, 2021
b18fe3f
Updated code for data type of offset and length
JyotiWhcl Nov 19, 2021
e3e9b09
Made changes in code for data type of offset and length
JyotiWhcl Nov 26, 2021
987feee
Resolved merge conflicts
JyotiWhcl Nov 26, 2021
e26fddc
Ignoring .idea pycharm files
JyotiWhcl Nov 26, 2021
3d9f761
Deleting .idea directory
JyotiWhcl Nov 26, 2021
ed8f16b
deleted .idea entries
JyotiWhcl Nov 30, 2021
511eb4e
deleted ./idea entries
JyotiWhcl Nov 30, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@ def __init__(self, api_client):

def create_results_connection(self, search_id, offset, length):
try:
min_range = offset
max_range = offset + length
min_range = int(offset)
max_range = min_range + int(length)

# Grab the response, extract the response code, and convert it to readable json
response = self.api_client.get_search_results(search_id)
response_code = response.code
response_txt = response.read()
# Construct a response object

return_obj = dict()
error_obj = dict()
if response_code == 200:
Expand All @@ -31,9 +33,9 @@ def create_results_connection(self, search_id, offset, length):
if isinstance(value, list) and value:
newdata+=value

# slice of the data count according to offset values
# slice off the data count according to offset values
if newdata and max_range > 0 and len(newdata) > max_range:
newdata = newdata[:max_range]
newdata = newdata[min_range:max_range]

for msg in newdata:
if "messageParts" in msg:
Expand Down