Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lint to Makefile #1

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Added lint to Makefile #1

merged 2 commits into from
Sep 19, 2023

Conversation

dhirajsb
Copy link
Contributor

No description provided.

@dhirajsb dhirajsb requested a review from tarilabs September 17, 2023 23:46
@dhirajsb
Copy link
Contributor Author

@tarilabs can you approve the first PR? 😄

tarilabs
tarilabs previously approved these changes Sep 18, 2023
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add however the instructions on how to install golangci-lint or have I missed it? 🤔

@dhirajsb
Copy link
Contributor Author

@tarilabs good point, will add it to prerequisites in README.

@dhirajsb dhirajsb merged commit 4aae325 into opendatahub-io:main Sep 19, 2023
@dhirajsb dhirajsb deleted the add-lint branch September 19, 2023 16:48
@lampajr lampajr mentioned this pull request Nov 14, 2023
dhirajsb pushed a commit to dhirajsb/model-registry that referenced this pull request Jan 20, 2025
dhirajsb pushed a commit to dhirajsb/model-registry that referenced this pull request Jan 20, 2025
…x-2.16

Review Dockerfile file for building odh-model-registry in konflux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants