feat: set domain automatically in Openshift cluster, fixes RHOAIENG-5123 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarilabs
previously approved these changes
Jul 12, 2024
| @@ -197,7 +197,7 @@ $(ENVTEST): $(LOCALBIN) | |||
| .PHONY: certificates | |||
| certificates: | |||
| # generate TLS certs | |||
| scripts/generate_certs.sh $(DOMAIN) | |||
| scripts/generate_certs.sh $(or $(DOMAIN),$(shell oc get ingresses.config/cluster -o jsonpath='{.spec.domain}')) | |||
There was a problem hiding this comment.
shouldn't this be guarded in case both of the two fails (retrieving env variable, executing oc get) so to handle the case none are successful call somewhere instead of inline?
There was a problem hiding this comment.
Makefile didn't make it easy to add logic easily, so I added a guard in the generate_certs.sh script. It'll make sure that a non-empty domain is used.
tarilabs
approved these changes
Jul 12, 2024
3 tasks
rareddy
pushed a commit
to rareddy/model-registry-operator
that referenced
this pull request
Oct 1, 2024
…123 (opendatahub-io#115) * feat: set domain automatically in Openshift cluster, fixes RHOAIENG-5123 * fix: add check for non-empty domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set domain automatically in Openshift cluster either from an env variable in the operator, or from Openshift cluster if available
Fixes RHOAIENG-5123
How Has This Been Tested?
The default istio.env config file now has an empty DOMAIN parameter
Merge criteria: