Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing value from istio.env #96

Merged

Conversation

tonyxrmdavidson
Copy link

@tonyxrmdavidson tonyxrmdavidson commented Jul 17, 2024

This commit will remove the value from the DOMAIN key in the istio.env file. It was mistakenly pushed with a value that varies. It no longer needs a value

Description

How Has This Been Tested?

This has been tested in the model-registry-operator via this PR

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This commit will remove the value from the DOMAIN key in the istio.env file.
It was mistakenly pushed with a value that varies.
It no longer needs a value

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>
@openshift-ci openshift-ci bot requested review from lampajr and nehachopra27 July 17, 2024 08:13
Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tonyxrmdavidson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tonyxrmdavidson tonyxrmdavidson marked this pull request as draft July 17, 2024 08:57
@tonyxrmdavidson tonyxrmdavidson marked this pull request as ready for review September 5, 2024 08:23
@openshift-ci openshift-ci bot requested a review from isinyaaa September 5, 2024 08:23
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

maybe @lugi0 or @nehachopra27 can chime-in, please?

I'm noting this is removing an hardcoded domain value, but I'm not fully experienced of the implications for this env?

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2024
@tarilabs tarilabs removed their assignment Sep 5, 2024
@tonyxrmdavidson
Copy link
Author

/lgtm

maybe @lugi0 or @nehachopra27 can chime-in, please?

I'm noting this is removing an hardcoded domain value, but I'm not fully experienced of the implications for this env?

This env file is only used as part of the openshift-ci test and the key value is dynamically set during the test run.

@openshift-merge-bot openshift-merge-bot bot merged commit 56a2713 into opendatahub-io:main Sep 5, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants