Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a plan for the transition from UBI9/8 images to C9S for ODH and RHEL for RHODS #105

Closed
atheo89 opened this issue May 24, 2023 · 3 comments
Labels
kind/feature New feature or request priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt)

Comments

@atheo89
Copy link
Member

atheo89 commented May 24, 2023

Due to a lot of missing packages on UBI-based images, it requires moving to CentOS Stream 9 base images on the upstream repo, and RHEL for the downstream.

Things to consider (so far):

  • This differentiation in the base image between the two repositories may lead to use two different repositories. Let's think about how we may avoid double maintenance. (Maybe by using submodules)
  • On downstream, we need to be registered on the subscription manager
@maroroman
Copy link

maroroman commented May 25, 2023

We had a conversation about this issue and identified a possible solution that would let us avoid having to maintain 2 repositories separately:

In the notebooks repo, for development purposes, there could be added an environment variable containing the base image chosen by the developer.
i.e. Instead of this:

# Build and push base-ubi8-python-3.8 image to the registry
.PHONY: base-ubi8-python-3.8
base-ubi8-python-3.8:
     $(call image,$@,base/ubi8-python-3.8)

We could use this:

# Build and push base image to the registry
.PHONY: base
base:
     $(call image,$@, ${BASE_IMAGE})

Where BASE_IMAGE=base/c9s-python-3.9 (or its equivalents chosen by the dev, like base/ubi9-python-3.9 for developing downstream)

And the rest of the images would use this base that has been set by the env var.

For CI purposes, a second PR would be created in https://github.com/openshift/release/blob/master/ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

There, all UBI images would be deleted, and replaced by their C9S equivalents, i.e.:

  - context_dir: base/ubi9-python-3.9
    dockerfile_path: Dockerfile
    to: base-ubi9-python-3.9
  - context_dir: jupyter/minimal/ubi9-python-3.9
    dockerfile_path: Dockerfile
    from: base-ubi9-python-3.9
    to: jupyter-minimal-ubi9-python-3.9

Would be replaced with:

  - context_dir: base/c9s-python-3.9
    dockerfile_path: Dockerfile
    to: base-c9s-python-3.9
  - context_dir: jupyter/minimal/c9s-python-3.9
    dockerfile_path: Dockerfile
    from: base-c9s-python-3.9
    to: jupyter-minimal-c9s-python-3.9

The downstream CI would not require changes in this case.

cc @atheo89 @harshad16
Let me know what you think about this solution.

@harshad16
Copy link
Member

Thanks for the possible solution for making the change.
Seems like a doable solution.

We should also evaluate the implication of making a change from centos and rhel
would like to cause any kinda concern downstream as well.

@harshad16 harshad16 added the kind/feature New feature or request label May 25, 2023
@harshad16 harshad16 changed the title [Tracker] Have a plan for the transition from UBI9/8 images to C9S for ODH and RHEL for RHODS Have a plan for the transition from UBI9/8 images to C9S for ODH and RHEL for RHODS Jun 16, 2023
@harshad16 harshad16 added the priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt) label Jul 25, 2023
harshad16 added a commit to harshad16/odh-notebooks that referenced this issue Jan 12, 2024
Co-authored-by: Harshad Reddy Nalla <hnalla@redhat.com>
jiridanek pushed a commit to jiridanek/notebooks that referenced this issue Feb 23, 2024
Co-authored-by: Harshad Reddy Nalla <hnalla@redhat.com>
@harshad16
Copy link
Member

Necessary image are split between UBI/Centos/RHEL.
Closing this issue as the requirements are fulfilled.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅Done in ODH IDE Planning Feb 23, 2024
jiridanek pushed a commit to jiridanek/notebooks that referenced this issue Jun 6, 2024
Co-authored-by: Harshad Reddy Nalla <hnalla@redhat.com>
jiridanek pushed a commit to jiridanek/notebooks that referenced this issue Jun 6, 2024
These changes shouldn't have any functional impact.

[fix] CI for the images checks based on recent updates

[fix] This fixes an inconsistency with the kustomize params

Inconsistency for codeserver notebook parameters. There was upstream
change recently that probably not got properly backported to downstream,
see [1,2].

* [1] opendatahub-io#524
* [2] red-hat-data-services@ceb3dc8

Set the rstudio builds with the branch rhoai-2.10

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Update image commits for release N via digest-updater-9215094498 GitHub action

Update images for release N via digest-updater-9215094498 GitHub action

Update file via  digest-updater-9213110410 GitHub action

Allow runtime script to cp the package from bin to Rpackage default path

Update codeflare-sdk version on imagestreams annotations (opendatahub-io#235)

* Update codeflare-sdk version on imagestreams annotations
* fix kfp version in the annotation for tensorflow

Co-authored-by: Jan Stourac <jstourac@redhat.com>

Update images for release N and N-1 with 2024a commit db8bd76

Update file via  digest-updater-8806399693 GitHub action

Update annotations for kfp (opendatahub-io#229)

Update image commits for release N via digest-updater-8665769109 GitHub action

Update images for release N via digest-updater-8665769109 GitHub action

Update manifest for code-freeze 2.9

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Update image commits for release N-1 via digest-updater-8581586298 GitHub action

Update images for release N-1 via digest-updater-8581586298 GitHub action

Update image commits for release N via digest-updater-8581586298 GitHub action

Update images for release N via digest-updater-8581586298 GitHub action

Update file via  digest-updater-8577545330 GitHub action

Fix the runtime updater github action branch 2024a

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Fix the runtime updater github action

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Remove the intel based image from the overlay as its ODH only
- Fix the typo in the datascience notebook

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Revert nginx version to 1.22 since 1.24 is not available on rhel yet

update cuda layer for RHEL to 12.1

Add runtimes workflow updater

Update digest updater workflow

Fix check-params-env test with the new changes (opendatahub-io#196)

Update Imagesteam for habana 1.13

Update runtime images with e1aee40 build commit

Update the manifests to retain old image in shadow state

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Update image commits for release N via digest-updater-8319475892 GitHub action

Update images for release N via digest-updater-8319475892 GitHub action

Update Codeserver ImageStream for the 2024a release inclusion (opendatahub-io#173)

* Update Codeserver imagestream with the 2024a release

Co-authored-by: Harshad Reddy Nalla <harshadreddy16@gmail.com>

Fix test file for the trustyai image

I don't really understand how and why this file was broken by this
commit aac0662 . Our CI check notifies
that something is broken in the file.

Update Imagestreams with in favor of the new release 2024.1 (opendatahub-io#175)

Co-authored-by: Harshad Reddy Nalla <hnalla@redhat.com>

Update digest updater workflow in favor 2024a release

Remove opendatahub.io/dashboard: 'true' label from rstudio ImageSteams

Create sync workflow for the release-2024a

Format yaml and json files to statisfy code-quality
- Fix validation of the params-env

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Update RStudio-server Dockefile for RHEL version

Fix library path version on rsession.conf file

hot fix: bump cuda resources

HotFix: Remove the annotation notebook-images=true from RStudio imagestreams

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Fix user R library path version

Update image commits for release N via digest-updater-7846262944 GitHub action

Update images for release N via digest-updater-7846262944 GitHub action

Remove the R-package install from workbench

Co-authored-by: Diamond Bryant <dibryant@redhat.com>
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Fix naming for RStudio Server on rhel flavor

Increase build resources for R Studio buildconfigs

Mount the secret on the buildConfig instead of using ENVs to avoid their expose on the logs

Adjust the imagestream annotation for codeflare-sdk upgrade

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Update image commits for release N via digest-updater-7761501425 GitHub action

Update images for release N via digest-updater-7761501425 GitHub action

Add optional: true option for the base and server url envs

Add BuildConfiguration objects to build RStudio and CUDA RStudio images on OCP cluster

Fixes on the CUDA Dockerfile

setup r-studio based with rhel9 base image (opendatahub-io#125)

* Content of R Studio switched to the rhel based image.

Add rhel9 base image

[Fix] typo in logging of the `notebook-digest-updater.yaml`

Update image commits for release N via digest-updater-7533330854 GitHub action

Update images for release N-1 via digest-updater-7533330854 GitHub action

Update images for release N via digest-updater-7533330854 GitHub action

Fix: update the code-server and annotation

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Co-authored-by: aTheo <atheodorak@outlook.com>

Incorporate VSCode on Downstream (opendatahub-io#105)

Co-authored-by: Harshad Reddy Nalla <hnalla@redhat.com>

hot-fix: Fix the tensorflow imagestream by removing the trailing space

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

hot-fix: Fix the imagestream minimal-cuda sha

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

hot-fix: Fixed imagestream with CVE 44487 changes

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

hot-fix: update the base ubi9 images for cve 44487 fix

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

hot-fix: CVE 44487 fix with libnghttp2

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Update the pipfile.lock via the weekly workflow action

chores: Update the runtime image with the commit: 8bda2fa

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Patch the imagestream by removing habana 1.11.0

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Update the runtime image with the commit: 8bda2fa on main

Update images for release N via digest-updater-6655629712 GitHub action

Fix the annotation and additional recommended-true

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Patch the imagestream to have same name as in odh-manifests

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Fix digest updater from failing if there are no updates on the image streams

Fix the path to the params.env file

Several fixes

Upgrade the notebook images with 2023b and 2023a images

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

Include only sync github workflow on the main branch

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt)
Projects
Status: No status
Archived in project
Development

No branches or pull requests

3 participants