feat: add codeflare sdk to datascience base image #196
Conversation
|
@rkpattnaik780 hey bro! Can you have a look at this pr? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rkpattnaik780 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
Hi @dimakis, This PR looks good overall, but I have a couple of suggestions that are needed: 1. Consistency Across OS Flavors: It's important to maintain consistency among the different flavors of OS in our notebooks. To do that, please make sure to add the codeflare-sdk package to the ubi8 data science notebook as well. 2. Updating the rest Pipfiles: Additionally, don't forget to update the Pipfiles for the following notebooks: PyTorch, TensorFlow, and TrustyAI (As well as on the corresponding runtimes). You can refer to the example line for guidance on how to make these updates. This will ensure that the dependencies are correctly aligned across all relevant notebooks. |
@atheo89, thank very much for your detailed reply. Due to a dependency on our end (which we hope to overcome soon) python 3.8 will not work with our stack, hence the inclusion in only 3.9. |
dimakis
force-pushed
the
addition-of-codeflare-sdk
branch
from
c79d237 to
3fcd893
Compare
|
New changes are detected. LGTM label has been removed. |
|
@atheo89 I've managed to have you seen this before? do you know how I'd get around it? should I just run |
It appears there is an inconsistency involving the tensorflow~=2.11.0 requirement. You might want to consider utilizing an earlier version of the Codeflare SDK. |
Even running it in a fresh dir, with a fresh venv won't allow me to Can the tensflow version be bumped, the current release is 2.13? 🤔 This is surely going to be a re-occurring problem and not one that I alone will face? |
|
We will indeed be updating all the notebooks in the upcoming release. Since |
|
Thanks for the PR. 💯
|
|
Closing this PR as it will be addressed as part of the upcoming notebooks upgrade. |
|
The codeflare would be also include in #205 and with these. |
harshad16
force-pushed
the
addition-of-codeflare-sdk
branch
from
3fcd893 to
e22b8cb
Compare
harshad16
force-pushed
the
addition-of-codeflare-sdk
branch
from
e22b8cb to
c5333cb
Compare
|
@dimakis: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
codeflare-sdk is installing seems like code-flare-SDK requires: which install This disrupt the whole notebook flow. |
|
Closing this PR, |
These changes shouldn't have any functional impact. [fix] CI for the images checks based on recent updates [fix] This fixes an inconsistency with the kustomize params Inconsistency for codeserver notebook parameters. There was upstream change recently that probably not got properly backported to downstream, see [1,2]. * [1] opendatahub-io#524 * [2] red-hat-data-services@ceb3dc8 Set the rstudio builds with the branch rhoai-2.10 Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Update image commits for release N via digest-updater-9215094498 GitHub action Update images for release N via digest-updater-9215094498 GitHub action Update file via digest-updater-9213110410 GitHub action Allow runtime script to cp the package from bin to Rpackage default path Update codeflare-sdk version on imagestreams annotations (opendatahub-io#235) * Update codeflare-sdk version on imagestreams annotations * fix kfp version in the annotation for tensorflow Co-authored-by: Jan Stourac <jstourac@redhat.com> Update images for release N and N-1 with 2024a commit db8bd76 Update file via digest-updater-8806399693 GitHub action Update annotations for kfp (opendatahub-io#229) Update image commits for release N via digest-updater-8665769109 GitHub action Update images for release N via digest-updater-8665769109 GitHub action Update manifest for code-freeze 2.9 Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Update image commits for release N-1 via digest-updater-8581586298 GitHub action Update images for release N-1 via digest-updater-8581586298 GitHub action Update image commits for release N via digest-updater-8581586298 GitHub action Update images for release N via digest-updater-8581586298 GitHub action Update file via digest-updater-8577545330 GitHub action Fix the runtime updater github action branch 2024a Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Fix the runtime updater github action Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Remove the intel based image from the overlay as its ODH only - Fix the typo in the datascience notebook Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Revert nginx version to 1.22 since 1.24 is not available on rhel yet update cuda layer for RHEL to 12.1 Add runtimes workflow updater Update digest updater workflow Fix check-params-env test with the new changes (opendatahub-io#196) Update Imagesteam for habana 1.13 Update runtime images with e1aee40 build commit Update the manifests to retain old image in shadow state Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Update image commits for release N via digest-updater-8319475892 GitHub action Update images for release N via digest-updater-8319475892 GitHub action Update Codeserver ImageStream for the 2024a release inclusion (opendatahub-io#173) * Update Codeserver imagestream with the 2024a release Co-authored-by: Harshad Reddy Nalla <harshadreddy16@gmail.com> Fix test file for the trustyai image I don't really understand how and why this file was broken by this commit aac0662 . Our CI check notifies that something is broken in the file. Update Imagestreams with in favor of the new release 2024.1 (opendatahub-io#175) Co-authored-by: Harshad Reddy Nalla <hnalla@redhat.com> Update digest updater workflow in favor 2024a release Remove opendatahub.io/dashboard: 'true' label from rstudio ImageSteams Create sync workflow for the release-2024a Format yaml and json files to statisfy code-quality - Fix validation of the params-env Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Update RStudio-server Dockefile for RHEL version Fix library path version on rsession.conf file hot fix: bump cuda resources HotFix: Remove the annotation notebook-images=true from RStudio imagestreams Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Fix user R library path version Update image commits for release N via digest-updater-7846262944 GitHub action Update images for release N via digest-updater-7846262944 GitHub action Remove the R-package install from workbench Co-authored-by: Diamond Bryant <dibryant@redhat.com> Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Fix naming for RStudio Server on rhel flavor Increase build resources for R Studio buildconfigs Mount the secret on the buildConfig instead of using ENVs to avoid their expose on the logs Adjust the imagestream annotation for codeflare-sdk upgrade Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Update image commits for release N via digest-updater-7761501425 GitHub action Update images for release N via digest-updater-7761501425 GitHub action Add optional: true option for the base and server url envs Add BuildConfiguration objects to build RStudio and CUDA RStudio images on OCP cluster Fixes on the CUDA Dockerfile setup r-studio based with rhel9 base image (opendatahub-io#125) * Content of R Studio switched to the rhel based image. Add rhel9 base image [Fix] typo in logging of the `notebook-digest-updater.yaml` Update image commits for release N via digest-updater-7533330854 GitHub action Update images for release N-1 via digest-updater-7533330854 GitHub action Update images for release N via digest-updater-7533330854 GitHub action Fix: update the code-server and annotation Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Co-authored-by: aTheo <atheodorak@outlook.com> Incorporate VSCode on Downstream (opendatahub-io#105) Co-authored-by: Harshad Reddy Nalla <hnalla@redhat.com> hot-fix: Fix the tensorflow imagestream by removing the trailing space Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> hot-fix: Fix the imagestream minimal-cuda sha Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> hot-fix: Fixed imagestream with CVE 44487 changes Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> hot-fix: update the base ubi9 images for cve 44487 fix Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> hot-fix: CVE 44487 fix with libnghttp2 Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Update the pipfile.lock via the weekly workflow action chores: Update the runtime image with the commit: 8bda2fa Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Patch the imagestream by removing habana 1.11.0 Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Update the runtime image with the commit: 8bda2fa on main Update images for release N via digest-updater-6655629712 GitHub action Fix the annotation and additional recommended-true Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Patch the imagestream to have same name as in odh-manifests Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Fix digest updater from failing if there are no updates on the image streams Fix the path to the params.env file Several fixes Upgrade the notebook images with 2023b and 2023a images Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Include only sync github workflow on the main branch Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Closes #197
Description
The addition of the CodeFlare SDK to interact with codeflare stack
How Has This Been Tested?
Merge criteria: