Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add codeflare sdk to datascience images #263

Merged

Conversation

harshad16
Copy link
Member

feature: add codeflare sdk to datascience images

Description

The addition of the CodeFlare SDK to interact with codeflare stack
Fixes: #197
Closes: #196
(Extension of 196)

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit c91d58c into opendatahub-io:2023b Oct 17, 2023
@atheo89 atheo89 mentioned this pull request Oct 20, 2023
@harshad16 harshad16 deleted the add-latest-codeflare-sdk branch October 20, 2023 18:25
@harshad16 harshad16 mentioned this pull request Oct 26, 2023
4 tasks
atheo89 pushed a commit to atheo89/notebooks that referenced this pull request Oct 8, 2024
[CI] add basic checks for params.env and commit.env files content and also runtime images check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants