-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade workbenches for the 2023b release #205
Conversation
5b5da32
to
fed0e42
Compare
5af81b5
to
6aa3fb7
Compare
/override ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @harshad16 @rkpattnaik780, I rebased this PR according to the new changes, could you take a look, please? Note: This PR is pointing to the main branch only for the CI tests, once this is reviewed it needs to point to the 2023b branch (I think the 2023b needs rebase as well from the main). |
bfdf2df
to
1350e9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work 💯
Thank you for your patience with the review
and for the great contribution.
Suggestion:
As this for the next upgrade release 2023b,
we should probably drop ubi8-python3.8
- pytorch, tensorflow
we would need minimal and data science for building Habana and other related images.
jupyter/datascience/ubi8-python-3.8/mongodb-org-6.0.repo-x86_64
Outdated
Show resolved
Hide resolved
/retest |
1 similar comment
/retest |
/test images |
/retest |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
this ready for approval.
i have move the target branch to 2023b.
can you please once rebase the change to that branch.
i will approve and merge once that done.
thank you.
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…s of the notebooks
…e dockerfile on the cuda layer Remove jupyterlab-s3-browser from datascience notebook Add skl2onnx, codeflare-sdk, pymongo, psycopg, mysql-connector-python, pyodbc python packages on the jupyter notebooks except minimal Install unixODBC in favor of pyodbc package Install cuda toolkit on c9s cuda base Update runtimes' python packages Upgrade packages on the ubi8 flavor of the notebooks Move installation of usefull os packages like jq unixODBC postgreql git-lfs libsndfile on the base image Upgrade packages on trustyAI ubi8 Add mongodb and mssql drivers on datascience notebook Consider setuptool on the pipfiles of the notebooks
Great it is done, I rebased this to 2023b. |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 🥇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For the record - this contains work also for #197. |
Sync the downstream only change from main to release-2024a
Upgrade workbenches for the 2023b release
Related to: #163
Ref: Releases N&N-1 Package Versions
Description
This PR includes several updates as they are on the following list:
Update all the notebooks (ubi8/ubi9) with the latest compatible versions on Python packages and libraries
Introduce new python packages and libraries
Update CUDA layer
Drop ubi8-python3.8 flavor for PyTorch and TensorFlow notebooks. We would need minimal and data science for building Habana and other related images. The related change on openshift-ci [ODH] Drop PyTorch and TensorFlow notebooks from 2023b branch openshift/release#43953
Housekeeping on the structure of the pipfiles
Note: This PR is pointing to the main branch only for the CI tests, once this is reviewed we have to point it to 2023b branch.
How Has This Been Tested?
Ensure that all the notebook images are running as expected, just need to
podman run -it --rm -p 8888:8888 quay.io/opendatahub/workbench-images:<NOTEBOOK_FLAVOR>-pr-205
Merge criteria: