Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade workbenches for the 2023b release #205

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Sep 6, 2023

Upgrade workbenches for the 2023b release

Related to: #163

Ref: Releases N&N-1 Package Versions

Description

This PR includes several updates as they are on the following list:

Note: This PR is pointing to the main branch only for the CI tests, once this is reviewed we have to point it to 2023b branch.

How Has This Been Tested?

Ensure that all the notebook images are running as expected, just need to
podman run -it --rm -p 8888:8888 quay.io/opendatahub/workbench-images:<NOTEBOOK_FLAVOR>-pr-205

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 force-pushed the wip-2023b branch 5 times, most recently from 5b5da32 to fed0e42 Compare September 8, 2023 07:46
@atheo89 atheo89 force-pushed the wip-2023b branch 2 times, most recently from 5af81b5 to 6aa3fb7 Compare September 12, 2023 13:53
@atheo89 atheo89 changed the title [WIP] Upgrade workbenches for the 2023b release Upgrade workbenches for the 2023b release Sep 13, 2023
@atheo89
Copy link
Member Author

atheo89 commented Sep 25, 2023

/override ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror

In response to this:

/override ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atheo89
Copy link
Member Author

atheo89 commented Sep 25, 2023

Hi @harshad16 @rkpattnaik780, I rebased this PR according to the new changes, could you take a look, please?

Note: This PR is pointing to the main branch only for the CI tests, once this is reviewed it needs to point to the 2023b branch (I think the 2023b needs rebase as well from the main).

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 💯
Thank you for your patience with the review
and for the great contribution.

Suggestion:
As this for the next upgrade release 2023b,
we should probably drop ubi8-python3.8

  • pytorch, tensorflow
    we would need minimal and data science for building Habana and other related images.

@atheo89
Copy link
Member Author

atheo89 commented Oct 4, 2023

/retest

1 similar comment
@atheo89
Copy link
Member Author

atheo89 commented Oct 4, 2023

/retest

@atheo89
Copy link
Member Author

atheo89 commented Oct 4, 2023

/test images

@atheo89
Copy link
Member Author

atheo89 commented Oct 4, 2023

/retest

@atheo89
Copy link
Member Author

atheo89 commented Oct 4, 2023

/retest-required

@harshad16 harshad16 changed the base branch from main to 2023b October 5, 2023 04:20
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
this ready for approval.
i have move the target branch to 2023b.
can you please once rebase the change to that branch.

i will approve and merge once that done.
thank you.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror 19e27bf link true /test jupyter-datascience-anaconda-python-3-8-pr-image-mirror
ci/prow/runtime-datascience-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test runtime-datascience-ubi8-python-3-8-pr-image-mirror
ci/prow/runtime-pytorch-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test runtime-pytorch-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-base-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test notebook-base-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-jupyter-trustyai-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-jupyter-trustyai-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-base-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-base-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-cuda-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test notebook-cuda-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-cuda-jupyter-minimal-ubi8-python-3-9-pr-image-mirror 8a511ff link true /test notebook-cuda-jupyter-minimal-ubi8-python-3-9-pr-image-mirror
ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test notebook-cuda-jupyter-tf-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-cuda-rstudio-c9s-python-3-9-pr-image-mirror 8a511ff link true /test notebook-cuda-rstudio-c9s-python-3-9-pr-image-mirror
ci/prow/notebook-codeserver-c9s-python-3-9-pr-image-mirror 8a511ff link true /test notebook-codeserver-c9s-python-3-9-pr-image-mirror
ci/prow/notebook-rstudio-c9s-python-3-9-pr-image-mirror 8a511ff link true /test notebook-rstudio-c9s-python-3-9-pr-image-mirror
ci/prow/notebook-cuda-c9s-python-3-9-pr-image-mirror 8a511ff link true /test notebook-cuda-c9s-python-3-9-pr-image-mirror
ci/prow/notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-habana-1-11-0-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-habana-1-11-0-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-habana-1-9-0-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-habana-1-9-0-ubi8-python-3-8-pr-image-mirror
ci/prow/runtime-datascience-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test runtime-datascience-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-minimal-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test runtime-minimal-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-pytorch-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test runtime-pytorch-ubi8-python-3-8-pr-image-mirror
ci/prow/runtime-cuda-tensorflow-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test runtime-cuda-tensorflow-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-jupyter-minimal-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test notebook-jupyter-minimal-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-jupyter-datascience-ubi9-python-3-9-pr-image-mirror 8a511ff link true /test notebook-jupyter-datascience-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-cuda-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-cuda-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-jupyter-pytorch-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-jupyter-pytorch-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-cuda-jupyter-tf-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test notebook-cuda-jupyter-tf-ubi8-python-3-8-pr-image-mirror
ci/prow/notebooks-e2e-tests 8a511ff link true /test notebooks-e2e-tests
ci/prow/runtime-cuda-tensorflow-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test runtime-cuda-tensorflow-ubi8-python-3-8-pr-image-mirror
ci/prow/runtime-minimal-ubi8-python-3-8-pr-image-mirror 8a511ff link true /test runtime-minimal-ubi8-python-3-8-pr-image-mirror
ci/prow/habana-notebooks-e2e-tests 8a511ff link true /test habana-notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

…e dockerfile on the cuda layer

Remove jupyterlab-s3-browser from datascience notebook

Add skl2onnx, codeflare-sdk, pymongo, psycopg, mysql-connector-python, pyodbc python packages on the jupyter notebooks except minimal

Install unixODBC in favor of pyodbc package

Install cuda toolkit on c9s cuda base

Update runtimes' python packages

Upgrade packages on the ubi8 flavor of the notebooks

Move installation of usefull os packages like jq unixODBC postgreql git-lfs libsndfile on the base image

Upgrade packages on trustyAI ubi8

Add mongodb and mssql drivers on datascience notebook

Consider setuptool on the pipfiles of the notebooks
@atheo89
Copy link
Member Author

atheo89 commented Oct 5, 2023

lgtm this ready for approval. i have move the target branch to 2023b. can you please once rebase the change to that branch.

i will approve and merge once that done. thank you.

Great it is done, I rebased this to 2023b.

@droslean
Copy link

droslean commented Oct 5, 2023

/test all

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 🥇

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member

For the record - this contains work also for #197.

harshad16 added a commit to harshad16/odh-notebooks that referenced this pull request Apr 9, 2024
Sync the downstream only change from main to release-2024a
@atheo89 atheo89 deleted the wip-2023b branch October 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants