Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyTorch should be installed from Torch repo, not from PyPi #98

Closed
Tracked by #163
guimou opened this issue May 18, 2023 · 2 comments
Closed
Tracked by #163

PyTorch should be installed from Torch repo, not from PyPi #98

guimou opened this issue May 18, 2023 · 2 comments
Assignees
@atheo89
Labels
kind/feature New feature or request priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt)
Milestone
2023b

Comments

@guimou
Copy link
Member

guimou commented May 18, 2023

As PyTorch comes with its own embedded CUDA, we have to make sure we match the CUDA version (and Toolkit) we install in the image with the one from PyTorch. The only way to that is to install from the original PyTorch repo: https://download.pytorch.org/whl/torch_stable.html
We can then specify the exact version we want, like torch==1.9.0+cu111, which would install Torch with CUDA11.1.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ODH IDE Planning May 18, 2023
@harshad16 harshad16 moved this from 📋 Backlog to 🔖Todo in ODH IDE Planning Jun 6, 2023
@atheo89 atheo89 mentioned this issue Jun 8, 2023
Closed
3 tasks
@atheo89 atheo89 linked a pull request Jun 8, 2023 that will close this issue
Update PyTorch notebook #111
Closed
3 tasks
@atheo89 atheo89 moved this from 🔖Todo to 🏗 In Progress in ODH IDE Planning Jun 8, 2023
@atheo89 atheo89 moved this from 🏗 In Progress to 👀 In Review in ODH IDE Planning Jun 14, 2023
@harshad16 harshad16 added the kind/feature New feature or request label Jun 16, 2023
@harshad16 harshad16 added this to the 2023b milestone Jun 20, 2023
@atheo89 atheo89 mentioned this issue Jun 30, 2023
Closed
6 tasks
@harshad16
Copy link
Member

harshad16 commented Jul 13, 2023 •
edited
Loading

The work was completed in sprint 1.29
The PR is kept in waiting state, as it update the pytorch version with major change
which is to be updated in 2023b cycle.
This issue would be stalled till that period.

keeping the issue in 1.29 for now
it would be moved to appropriate sprint as august starts.

@harshad16 harshad16 added the priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt) label Jul 25, 2023
@harshad16 harshad16 mentioned this issue Aug 10, 2023
Closed
15 tasks
This was referenced Sep 1, 2023
Closed
Merged
@harshad16
Copy link
Member

Complete with #205
Thanks for the work.

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅Done in ODH IDE Planning Oct 12, 2023
harshad16 added a commit to harshad16/odh-notebooks that referenced this issue Nov 16, 2023
@harshad16
Merge pull request opendatahub-io#98 from harshad16/update-v2.4-fix-i…
a37a988 
…mages

Update notebook image with the codeflare fix, commit: 859930e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheo89 atheo89

Labels
kind/feature New feature or request priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt)
Projects
ODH Feature Tracking
Status: No status
ODH IDE Planning
Archived in project
Milestone
2023b
Development

Successfully merging a pull request may close this issue.

Update PyTorch notebook atheo89/notebooks
3 participants
@guimou @harshad16 @atheo89