Rebase VSCode to UBI9 instead on C9S

[atheo89]

This PR rebases the VSCode to UBI9 instead on C9S. The reason is to facilitate the QE testing on upstream as well as will facilitate the meintenance among both streams.

Description

The functionality on the VSCode remains the same as in C9S

NOTE: OCP-CI change -> openshift/release#45451

How Has This Been Tested?

The behavior of the notebook looks the same as the one based on C9S.

1. On a Local Run

1. Build the notebook: make codeserver-ubi9-python-3.9

2. Run the VSCode locally:
   podman run --network=host --name validation-container quay.io/opendatahub/workbench-images:codeserver-ubi9-python-3.9-pr-319

3. On the terminal's logs there is the HTTP Server listening URL: http://0.0.0.0:8787/
   Need to press it in order to lunch the notebook

Once you finish the inspection: podman stop validation-container && podman rm validation-container

2. On the Cluster

Deploy on the cluster: make deploy9-codeserver-ubi9-python-3.9
Run the Test: make validate-codeserver-image image=codeserver-ubi9-python-3.9-pr-319 ensure that the test completed successfully
Undeploy: make undeploy9-codeserver-ubi9-python-3.9

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[atheo89]

/hold

[atheo89]

/unhold

[jstourac]

The reason is to facilitate the QE testing on upstream as well as will facilitate the meintenance among both streams.

I would say that not only that - having this on UBI means:

• a little smaller result image
• unifies with all other existing images since these are build on UBI too

[atheo89]

The reason is to facilitate the QE testing on upstream as well as will facilitate the meintenance among both streams.

I would say that not only that - having this on UBI means:

• a little smaller result image
• unifies with all other existing images since these are build on UBI too

Thanks Jan!

[jstourac]

LGTM

btw - thank you for the verification steps, it was really helpful so one doesn't have to figuring these things out! 👍

[harshad16]

Thanks for the work.
/lgtm

Providing my lgtm, i have one note
with the commit c15d4f7
we are changing the workdir to workspace.
if user keeps working on this dir, they would run of space, as PVC is mount on /opt/app-root/src.
we can get this in feature freeze and keep testing this.

[atheo89]

i have one note with the commit c15d4f7 we are changing the workdir to workspace. if user keeps working on this dir, they would run of space, as PVC is mount on /opt/app-root/src. we can get this in feature freeze and keep testing this.

@harshad16 Thanks a lot for raising this concern, I hadn't test this last change on cluster, and indeed you were right. When a user start up the notebook there was a popup window with the message: Workspace does not exists Like the print screen below, so, the user had to switch back to /src

So, I removed the old one and directed it to /opt/app-root/src/lost+found (as is also on the jupyter notebooks) . With this change is working as expected. No popup windows on the startup:

Testing part

I have created a test branch with this change on my repo to test it on the cluster. You can utilize the following part on the DSC to check that change.

    workbenches:
      devFlags:
        manifests:
          - contextDir: components/odh-notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/kubeflow/tarball/v1.7.0-5'
          - contextDir: components/notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/kubeflow/tarball/v1.7.0-5'
          - contextDir: manifests
            sourcePath: ''
            uri: 'https://github.com/atheo89/notebooks/tarball/workdir-change'
      managementState: Managed

Or, you can replace the generated image from this PR quay.io/opendatahub/workbench-images@sha256:e1fec835ee3f8ecb8e9380fb23992a7b37876e8b7164b773c95872f47baa688c inside the code-server imagestream directly into the cluster. (I didn't try this way)

[atheo89]

Open this Fix in ocp-ci for the e2e failure -> openshift/release#45567

[atheo89]

/test notebooks-e2e-tests

[atheo89]

Hi folks, I removed the last changes in regards the redirection to lost&found, as we discussed, these can be included a later as bug fixes. Could you take a last review?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment