Part1: Rebase VSCode to be built from ubi9 [main] [ODH] #45451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
3 tasks
atheo89
force-pushed
the
rebase-vscode-ubi9
branch
from
ad17abc to
416f1dc
Compare
harshad16
reviewed
Nov 9, 2023
atheo89
force-pushed
the
rebase-vscode-ubi9
branch
from
416f1dc to
5e9df01
Compare
atheo89
force-pushed
the
rebase-vscode-ubi9
branch
from
5e9df01 to
088d8ca
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
atheo89
changed the title
atheo89
changed the title
atheo89
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89, harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
5 tasks
|
@atheo89: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this pr change the configuration on the main configuration to build the vscode notebook from ubi9.
Configurations that changed:
Note: Follow up for the 2023a and 2023b configurations -> #45492