-
Notifications
You must be signed in to change notification settings - Fork 225
Apply hardware profile to notebook image settings table #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply hardware profile to notebook image settings table #3645
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3645 +/- ##
==========================================
- Coverage 84.26% 84.17% -0.10%
==========================================
Files 1450 1452 +2
Lines 33766 33823 +57
Branches 9353 9369 +16
==========================================
+ Hits 28454 28471 +17
- Misses 5312 5352 +40
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@DaoDaoNoCode , I created notebook image with a new option(ex: gpu) for rest of the functionality mentioned are working as expected |
@DaoDaoNoCode , thanks for the changes, that works well |
frontend/src/pages/BYONImages/BYONImageModal/HardwareProfileIdentifierMultiselect.tsx
Show resolved
Hide resolved
frontend/src/pages/BYONImages/BYONImageModal/HardwareProfileIdentifierMultiselect.tsx
Show resolved
Hide resolved
d8f7675
to
c9199e5
Compare
Change the hardware profile part to reuse the current recommended accelerator identifiers annotation for better migrating and avoiding some bugs. |
edc1ccc
to
2f39c85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
10d7434
into
opendatahub-io:main
…pendatahub-io#3662) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing intermediate changes * Initial changes * Initial changes * Messy working test * Committing working test - not linted/cleaned up * Committing working test with exception of status check on UI * Committing fully working test on RHOAI * Linting fixes * Adding in description for bug relating to manifest links * Actioning PR comments * Comitting initial changes * Comitting working test for Single Model Creation * Comitting final completed test * Small amendment to select model server on ODH * Linting after merge conflict resolution --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> made wording more consistent in storage dialog (opendatahub-io#3665) remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666) Co-authored-by: “Bob <“bgregor@redhat.com”> Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit * Fixed linting * adding package json * Swapped out cypress:run for cypress:e2e --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> Adds required to environment variables (opendatahub-io#3653) * Adds required to environment variables * Accessibility fix Fix for notebook route link font size (opendatahub-io#3678) Update the positions of DW tabs (opendatahub-io#3677) Add default deployment mode selector as read only (opendatahub-io#3664) * Add default deployment mode selector read only * Use DashboardHelpTooltip and fix popper width Fix for page header layout when page has long description (opendatahub-io#3679) Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682) feat: remove the NIM tile from Enabled page (opendatahub-io#3663) * feat: remove the NIM tile from Enabled page Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: rename function Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: add space after the here. Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680) * fix: label update for nim from single serving to NVIDIA NIM Serving Enabled Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: fix cypress test Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687) Signed-off-by: Olga Lavtar <olavtar@redhat.com> Apply hardware profile to notebook image settings table (opendatahub-io#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests refractor UsageBar and StorageSizeBar (opendatahub-io#3667) Hardware Profile Display Name is not trimmed (opendatahub-io#3670) Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672) CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685)
* Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (#3662) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing intermediate changes * Initial changes * Initial changes * Messy working test * Committing working test - not linted/cleaned up * Committing working test with exception of status check on UI * Committing fully working test on RHOAI * Linting fixes * Adding in description for bug relating to manifest links * Actioning PR comments * Comitting initial changes * Comitting working test for Single Model Creation * Comitting final completed test * Small amendment to select model server on ODH * Linting after merge conflict resolution --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> made wording more consistent in storage dialog (#3665) remove deprecated enabled nvidia manifest from rhoai (#3666) Co-authored-by: “Bob <“bgregor@redhat.com”> Add Exclusions to Cypress e2e Nightly Executions (#3671) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit * Fixed linting * adding package json * Swapped out cypress:run for cypress:e2e --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> Adds required to environment variables (#3653) * Adds required to environment variables * Accessibility fix Fix for notebook route link font size (#3678) Update the positions of DW tabs (#3677) Add default deployment mode selector as read only (#3664) * Add default deployment mode selector read only * Use DashboardHelpTooltip and fix popper width Fix for page header layout when page has long description (#3679) Update ownedByDSC to use correct label for checking what is created by operator (#3682) feat: remove the NIM tile from Enabled page (#3663) * feat: remove the NIM tile from Enabled page Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: rename function Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: add space after the here. Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (#3680) * fix: label update for nim from single serving to NVIDIA NIM Serving Enabled Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: fix cypress test Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: move the permissions from the cluster-role to the role yaml file (#3687) Signed-off-by: Olga Lavtar <olavtar@redhat.com> Apply hardware profile to notebook image settings table (#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests refractor UsageBar and StorageSizeBar (#3667) Hardware Profile Display Name is not trimmed (#3670) Name, resource label, tolerations and Node selector fields - Unlimited size string (#3672) CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (#3685) * Comitting working tests * Small wording changes --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>
…io#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests
…hub-io#3696) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (opendatahub-io#3662) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing intermediate changes * Initial changes * Initial changes * Messy working test * Committing working test - not linted/cleaned up * Committing working test with exception of status check on UI * Committing fully working test on RHOAI * Linting fixes * Adding in description for bug relating to manifest links * Actioning PR comments * Comitting initial changes * Comitting working test for Single Model Creation * Comitting final completed test * Small amendment to select model server on ODH * Linting after merge conflict resolution --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> made wording more consistent in storage dialog (opendatahub-io#3665) remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666) Co-authored-by: “Bob <“bgregor@redhat.com”> Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit * Fixed linting * adding package json * Swapped out cypress:run for cypress:e2e --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> Adds required to environment variables (opendatahub-io#3653) * Adds required to environment variables * Accessibility fix Fix for notebook route link font size (opendatahub-io#3678) Update the positions of DW tabs (opendatahub-io#3677) Add default deployment mode selector as read only (opendatahub-io#3664) * Add default deployment mode selector read only * Use DashboardHelpTooltip and fix popper width Fix for page header layout when page has long description (opendatahub-io#3679) Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682) feat: remove the NIM tile from Enabled page (opendatahub-io#3663) * feat: remove the NIM tile from Enabled page Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: rename function Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: add space after the here. Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680) * fix: label update for nim from single serving to NVIDIA NIM Serving Enabled Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: fix cypress test Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687) Signed-off-by: Olga Lavtar <olavtar@redhat.com> Apply hardware profile to notebook image settings table (opendatahub-io#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests refractor UsageBar and StorageSizeBar (opendatahub-io#3667) Hardware Profile Display Name is not trimmed (opendatahub-io#3670) Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672) CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685) * Comitting working tests * Small wording changes --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>
…hub-io#3696) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (opendatahub-io#3662) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing intermediate changes * Initial changes * Initial changes * Messy working test * Committing working test - not linted/cleaned up * Committing working test with exception of status check on UI * Committing fully working test on RHOAI * Linting fixes * Adding in description for bug relating to manifest links * Actioning PR comments * Comitting initial changes * Comitting working test for Single Model Creation * Comitting final completed test * Small amendment to select model server on ODH * Linting after merge conflict resolution --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> made wording more consistent in storage dialog (opendatahub-io#3665) remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666) Co-authored-by: “Bob <“bgregor@redhat.com”> Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit * Fixed linting * adding package json * Swapped out cypress:run for cypress:e2e --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> Adds required to environment variables (opendatahub-io#3653) * Adds required to environment variables * Accessibility fix Fix for notebook route link font size (opendatahub-io#3678) Update the positions of DW tabs (opendatahub-io#3677) Add default deployment mode selector as read only (opendatahub-io#3664) * Add default deployment mode selector read only * Use DashboardHelpTooltip and fix popper width Fix for page header layout when page has long description (opendatahub-io#3679) Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682) feat: remove the NIM tile from Enabled page (opendatahub-io#3663) * feat: remove the NIM tile from Enabled page Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: rename function Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: add space after the here. Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680) * fix: label update for nim from single serving to NVIDIA NIM Serving Enabled Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: fix cypress test Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687) Signed-off-by: Olga Lavtar <olavtar@redhat.com> Apply hardware profile to notebook image settings table (opendatahub-io#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests refractor UsageBar and StorageSizeBar (opendatahub-io#3667) Hardware Profile Display Name is not trimmed (opendatahub-io#3670) Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672) CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685) * Comitting working tests * Small wording changes --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>
…io#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests
…hub-io#3696) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (opendatahub-io#3662) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing intermediate changes * Initial changes * Initial changes * Messy working test * Committing working test - not linted/cleaned up * Committing working test with exception of status check on UI * Committing fully working test on RHOAI * Linting fixes * Adding in description for bug relating to manifest links * Actioning PR comments * Comitting initial changes * Comitting working test for Single Model Creation * Comitting final completed test * Small amendment to select model server on ODH * Linting after merge conflict resolution --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> made wording more consistent in storage dialog (opendatahub-io#3665) remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666) Co-authored-by: “Bob <“bgregor@redhat.com”> Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit * Fixed linting * adding package json * Swapped out cypress:run for cypress:e2e --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> Adds required to environment variables (opendatahub-io#3653) * Adds required to environment variables * Accessibility fix Fix for notebook route link font size (opendatahub-io#3678) Update the positions of DW tabs (opendatahub-io#3677) Add default deployment mode selector as read only (opendatahub-io#3664) * Add default deployment mode selector read only * Use DashboardHelpTooltip and fix popper width Fix for page header layout when page has long description (opendatahub-io#3679) Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682) feat: remove the NIM tile from Enabled page (opendatahub-io#3663) * feat: remove the NIM tile from Enabled page Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: rename function Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: add space after the here. Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680) * fix: label update for nim from single serving to NVIDIA NIM Serving Enabled Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: fix cypress test Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687) Signed-off-by: Olga Lavtar <olavtar@redhat.com> Apply hardware profile to notebook image settings table (opendatahub-io#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests refractor UsageBar and StorageSizeBar (opendatahub-io#3667) Hardware Profile Display Name is not trimmed (opendatahub-io#3670) Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672) CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685) * Comitting working tests * Small wording changes --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>
JIRA: RHOAIENG-16258
Description
Apply the hardware profiles to the notebook image settings page. This remains unchanged when the hardware profile flag is disabled. When it's enabled, do the following changes:
Recommended identifiers
withRecommended hardware profiles
and put all the hardware profiles that has the selected identifier (as long as at least one identifier is included in the hardware profile node resources, we think that hardware profile is recommended)How Has This Been Tested?
Test Impact
Added a unit test to test the recommended hardware profile filter function, and added a cypress test to test the pre-fill node resources table based on the search params in the URL.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main