Skip to content

Apply hardware profile to notebook image settings table #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Jan 14, 2025

JIRA: RHOAIENG-16258

Description

Apply the hardware profiles to the notebook image settings page. This remains unchanged when the hardware profile flag is disabled. When it's enabled, do the following changes:

  1. Replace the identifiers selector in the import/edit modal of the notebook image, and map all the hardware profile identifiers in the node resources table (except 'cpu' and 'memory' as they are the default ones)
Screenshot 2025-01-14 at 3 51 47 PM
  1. Replace the column Recommended identifiers with Recommended hardware profiles and put all the hardware profiles that has the selected identifier (as long as at least one identifier is included in the hardware profile node resources, we think that hardware profile is recommended)
Screenshot 2025-01-14 at 3 57 30 PM
  1. When creating the hardware profile from the column, navigate it to the create hardware profile page and pre-fill the node resources table with the current recommended identifier(s)
Screenshot 2025-01-14 at 3 52 04 PM

How Has This Been Tested?

  1. Turn on hardware profile feature flag
  2. Create some hardware profiles with different custom identifiers in the node resources table
  3. Go to notebook image settings page
  4. Edit a notebook image, choose the identifier(s)
  5. Make sure the hardware profiles that contain the identifier(s) are listed on the recommended column
  6. Try to create a profile from this page, you will see the identifiers are filled in the search params in the URL
  7. The node resources table should be pre-filled with the information in the URL

Test Impact

Added a unit test to test the recommended hardware profile filter function, and added a cypress test to test the pre-fill node resources table based on the search params in the URL.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from alexcreasy and dpanshug January 14, 2025 21:04
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (be0ba94) to head (f381496).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...src/pages/BYONImages/BYONImageHardwareProfiles.tsx 73.68% 5 Missing ⚠️
...BYONImages/BYONImageModal/ManageBYONImageModal.tsx 80.00% 1 Missing ⚠️
...ontend/src/pages/BYONImages/BYONImagesTableRow.tsx 75.00% 1 Missing ⚠️
frontend/src/pages/BYONImages/tableData.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3645      +/-   ##
==========================================
- Coverage   84.26%   84.17%   -0.10%     
==========================================
  Files        1450     1452       +2     
  Lines       33766    33823      +57     
  Branches     9353     9369      +16     
==========================================
+ Hits        28454    28471      +17     
- Misses       5312     5352      +40     
Files with missing lines Coverage Δ
backend/src/routes/api/images/imageUtils.ts 14.57% <100.00%> (ø)
...mageModal/HardwareProfileIdentifierMultiselect.tsx 100.00% <100.00%> (ø)
frontend/src/pages/BYONImages/BYONImagesTable.tsx 93.33% <100.00%> (+0.15%) ⬆️
frontend/src/pages/BYONImages/utils.ts 100.00% <100.00%> (ø)
...ages/hardwareProfiles/HardwareProfilesTableRow.tsx 84.37% <ø> (ø)
...dwareProfiles/manage/ManageNodeResourceSection.tsx 97.22% <100.00%> (+1.06%) ⬆️
...BYONImages/BYONImageModal/ManageBYONImageModal.tsx 91.83% <80.00%> (-1.50%) ⬇️
...ontend/src/pages/BYONImages/BYONImagesTableRow.tsx 84.00% <75.00%> (-1.72%) ⬇️
frontend/src/pages/BYONImages/tableData.tsx 77.77% <50.00%> (-9.73%) ⬇️
...src/pages/BYONImages/BYONImageHardwareProfiles.tsx 73.68% <73.68%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0ba94...f381496. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Jan 15, 2025

@DaoDaoNoCode , I created notebook image with a new option(ex: gpu) for Hardware profile identifier and then clicking on create profile in the Recommended hardware profiles column , navigate it to the create hardware profile page and pre-fill the node resources table with the current recommended identifier(s)(ex: gpu) , I created the hardware profile with recommended identifiers, editing the newly created hardware profile doesnt show up the recomended identifier(ex: gpu)

rest of the functionality mentioned are working as expected

@pnaik1
Copy link
Contributor

pnaik1 commented Jan 16, 2025

@DaoDaoNoCode , thanks for the changes, that works well
/lgtm

@DaoDaoNoCode
Copy link
Member Author

Change the hardware profile part to reuse the current recommended accelerator identifiers annotation for better migrating and avoiding some bugs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 10d7434 into opendatahub-io:main Jan 27, 2025
29 checks passed
antowaddle added a commit to antowaddle/odh-dashboard that referenced this pull request Jan 29, 2025
…pendatahub-io#3662)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Committing intermediate changes

* Initial changes

* Initial changes

* Messy working test

* Committing working test - not linted/cleaned up

* Committing working test with exception of status check on UI

* Committing fully working test on RHOAI

* Linting fixes

* Adding in description for bug relating to manifest links

* Actioning PR comments

* Comitting initial changes

* Comitting working test for Single Model Creation

* Comitting final completed test

* Small amendment to select model server on ODH

* Linting after merge conflict resolution

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

made wording more consistent in storage dialog (opendatahub-io#3665)

remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666)

Co-authored-by: “Bob <“bgregor@redhat.com”>

Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Initial commit

* Fixed linting

* adding package json

* Swapped out cypress:run for cypress:e2e

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

Adds required to environment variables (opendatahub-io#3653)

* Adds required to environment variables

* Accessibility fix

Fix for notebook route link font size (opendatahub-io#3678)

Update the positions of DW tabs (opendatahub-io#3677)

Add default deployment mode selector as read only (opendatahub-io#3664)

* Add default deployment mode selector read only

* Use DashboardHelpTooltip and fix popper width

Fix for page header layout when page has long description (opendatahub-io#3679)

Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682)

feat: remove the NIM tile from Enabled page (opendatahub-io#3663)

* feat: remove the NIM tile from Enabled page

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: rename function

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: add space after the here.

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680)

* fix: label update for nim from single serving to NVIDIA NIM Serving Enabled

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: fix cypress test

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687)

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

Apply hardware profile to notebook image settings table (opendatahub-io#3645)

* Apply hardware profile to notebook image settings table

* address comment

* add name tooltip for the hardware profile table

* Reuse recommended accelerator annotation for hardware profiles

* Change name resource field to fix layout issues

* fix tests

refractor UsageBar and StorageSizeBar (opendatahub-io#3667)

Hardware Profile Display Name is not trimmed (opendatahub-io#3670)

Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672)

CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685)
openshift-merge-bot bot pushed a commit that referenced this pull request Jan 30, 2025
* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (#3662)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Committing intermediate changes

* Initial changes

* Initial changes

* Messy working test

* Committing working test - not linted/cleaned up

* Committing working test with exception of status check on UI

* Committing fully working test on RHOAI

* Linting fixes

* Adding in description for bug relating to manifest links

* Actioning PR comments

* Comitting initial changes

* Comitting working test for Single Model Creation

* Comitting final completed test

* Small amendment to select model server on ODH

* Linting after merge conflict resolution

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

made wording more consistent in storage dialog (#3665)

remove deprecated enabled nvidia manifest from rhoai (#3666)

Co-authored-by: “Bob <“bgregor@redhat.com”>

Add Exclusions to Cypress e2e Nightly Executions (#3671)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Initial commit

* Fixed linting

* adding package json

* Swapped out cypress:run for cypress:e2e

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

Adds required to environment variables (#3653)

* Adds required to environment variables

* Accessibility fix

Fix for notebook route link font size (#3678)

Update the positions of DW tabs (#3677)

Add default deployment mode selector as read only (#3664)

* Add default deployment mode selector read only

* Use DashboardHelpTooltip and fix popper width

Fix for page header layout when page has long description (#3679)

Update ownedByDSC to use correct label for checking what is created by operator (#3682)

feat: remove the NIM tile from Enabled page (#3663)

* feat: remove the NIM tile from Enabled page

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: rename function

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: add space after the here.

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (#3680)

* fix: label update for nim from single serving to NVIDIA NIM Serving Enabled

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: fix cypress test

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: move the permissions from the cluster-role to the role yaml file (#3687)

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

Apply hardware profile to notebook image settings table (#3645)

* Apply hardware profile to notebook image settings table

* address comment

* add name tooltip for the hardware profile table

* Reuse recommended accelerator annotation for hardware profiles

* Change name resource field to fix layout issues

* fix tests

refractor UsageBar and StorageSizeBar (#3667)

Hardware Profile Display Name is not trimmed (#3670)

Name, resource label, tolerations and Node selector fields - Unlimited size string (#3672)

CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (#3685)

* Comitting working tests

* Small wording changes

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>
ashley-o0o pushed a commit to ashley-o0o/odh-dashboard that referenced this pull request Feb 7, 2025
…io#3645)

* Apply hardware profile to notebook image settings table

* address comment

* add name tooltip for the hardware profile table

* Reuse recommended accelerator annotation for hardware profiles

* Change name resource field to fix layout issues

* fix tests
ashley-o0o pushed a commit to ashley-o0o/odh-dashboard that referenced this pull request Feb 7, 2025
…hub-io#3696)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (opendatahub-io#3662)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Committing intermediate changes

* Initial changes

* Initial changes

* Messy working test

* Committing working test - not linted/cleaned up

* Committing working test with exception of status check on UI

* Committing fully working test on RHOAI

* Linting fixes

* Adding in description for bug relating to manifest links

* Actioning PR comments

* Comitting initial changes

* Comitting working test for Single Model Creation

* Comitting final completed test

* Small amendment to select model server on ODH

* Linting after merge conflict resolution

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

made wording more consistent in storage dialog (opendatahub-io#3665)

remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666)

Co-authored-by: “Bob <“bgregor@redhat.com”>

Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Initial commit

* Fixed linting

* adding package json

* Swapped out cypress:run for cypress:e2e

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

Adds required to environment variables (opendatahub-io#3653)

* Adds required to environment variables

* Accessibility fix

Fix for notebook route link font size (opendatahub-io#3678)

Update the positions of DW tabs (opendatahub-io#3677)

Add default deployment mode selector as read only (opendatahub-io#3664)

* Add default deployment mode selector read only

* Use DashboardHelpTooltip and fix popper width

Fix for page header layout when page has long description (opendatahub-io#3679)

Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682)

feat: remove the NIM tile from Enabled page (opendatahub-io#3663)

* feat: remove the NIM tile from Enabled page

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: rename function

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: add space after the here.

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680)

* fix: label update for nim from single serving to NVIDIA NIM Serving Enabled

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: fix cypress test

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687)

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

Apply hardware profile to notebook image settings table (opendatahub-io#3645)

* Apply hardware profile to notebook image settings table

* address comment

* add name tooltip for the hardware profile table

* Reuse recommended accelerator annotation for hardware profiles

* Change name resource field to fix layout issues

* fix tests

refractor UsageBar and StorageSizeBar (opendatahub-io#3667)

Hardware Profile Display Name is not trimmed (opendatahub-io#3670)

Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672)

CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685)

* Comitting working tests

* Small wording changes

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>
ugiordan pushed a commit to ugiordan/odh-dashboard that referenced this pull request Feb 10, 2025
…hub-io#3696)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (opendatahub-io#3662)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Committing intermediate changes

* Initial changes

* Initial changes

* Messy working test

* Committing working test - not linted/cleaned up

* Committing working test with exception of status check on UI

* Committing fully working test on RHOAI

* Linting fixes

* Adding in description for bug relating to manifest links

* Actioning PR comments

* Comitting initial changes

* Comitting working test for Single Model Creation

* Comitting final completed test

* Small amendment to select model server on ODH

* Linting after merge conflict resolution

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

made wording more consistent in storage dialog (opendatahub-io#3665)

remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666)

Co-authored-by: “Bob <“bgregor@redhat.com”>

Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Initial commit

* Fixed linting

* adding package json

* Swapped out cypress:run for cypress:e2e

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

Adds required to environment variables (opendatahub-io#3653)

* Adds required to environment variables

* Accessibility fix

Fix for notebook route link font size (opendatahub-io#3678)

Update the positions of DW tabs (opendatahub-io#3677)

Add default deployment mode selector as read only (opendatahub-io#3664)

* Add default deployment mode selector read only

* Use DashboardHelpTooltip and fix popper width

Fix for page header layout when page has long description (opendatahub-io#3679)

Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682)

feat: remove the NIM tile from Enabled page (opendatahub-io#3663)

* feat: remove the NIM tile from Enabled page

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: rename function

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: add space after the here.

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680)

* fix: label update for nim from single serving to NVIDIA NIM Serving Enabled

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: fix cypress test

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687)

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

Apply hardware profile to notebook image settings table (opendatahub-io#3645)

* Apply hardware profile to notebook image settings table

* address comment

* add name tooltip for the hardware profile table

* Reuse recommended accelerator annotation for hardware profiles

* Change name resource field to fix layout issues

* fix tests

refractor UsageBar and StorageSizeBar (opendatahub-io#3667)

Hardware Profile Display Name is not trimmed (opendatahub-io#3670)

Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672)

CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685)

* Comitting working tests

* Small wording changes

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>
manaswinidas pushed a commit to manaswinidas/odh-dashboard that referenced this pull request Feb 24, 2025
…io#3645)

* Apply hardware profile to notebook image settings table

* address comment

* add name tooltip for the hardware profile table

* Reuse recommended accelerator annotation for hardware profiles

* Change name resource field to fix layout issues

* fix tests
manaswinidas pushed a commit to manaswinidas/odh-dashboard that referenced this pull request Feb 24, 2025
…hub-io#3696)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (opendatahub-io#3662)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Committing intermediate changes

* Initial changes

* Initial changes

* Messy working test

* Committing working test - not linted/cleaned up

* Committing working test with exception of status check on UI

* Committing fully working test on RHOAI

* Linting fixes

* Adding in description for bug relating to manifest links

* Actioning PR comments

* Comitting initial changes

* Comitting working test for Single Model Creation

* Comitting final completed test

* Small amendment to select model server on ODH

* Linting after merge conflict resolution

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

made wording more consistent in storage dialog (opendatahub-io#3665)

remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666)

Co-authored-by: “Bob <“bgregor@redhat.com”>

Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671)

* Initial WIP version of resource creation test

* Experimental changes to poll the UI for updates

* Working version if resource is present

* increase card timeout and delete active wait

* Added changes to find namespace from variables

* Final changes to read variables, cleaned up utils

* Small change to a comment

* Dummy change to trigger mocks

* Save changes on cypress-RHOAIENG-12649

* Changed file directories and names as requested on a PR comment

* Saving changes to current branch

* Additional directory/file name changes

* Additional changes to save

* Resolving timeout issue breaking mock tests, also resolved latest PR comments

* Further changes for this test

* Changes to revert the exist method appended to getCardView.

* Fixed linting

* Linting fixes

* Final comments added

* Fixed merge conflict

* Small change to page object name

* dummy commit

* Removed RHOAI bug workaround

* Removed comments

* Last comment change

* Initial commit

* Fixed linting

* adding package json

* Swapped out cypress:run for cypress:e2e

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>

Adds required to environment variables (opendatahub-io#3653)

* Adds required to environment variables

* Accessibility fix

Fix for notebook route link font size (opendatahub-io#3678)

Update the positions of DW tabs (opendatahub-io#3677)

Add default deployment mode selector as read only (opendatahub-io#3664)

* Add default deployment mode selector read only

* Use DashboardHelpTooltip and fix popper width

Fix for page header layout when page has long description (opendatahub-io#3679)

Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682)

feat: remove the NIM tile from Enabled page (opendatahub-io#3663)

* feat: remove the NIM tile from Enabled page

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: rename function

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: add space after the here.

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680)

* fix: label update for nim from single serving to NVIDIA NIM Serving Enabled

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: label update

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

* fix: fix cypress test

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

---------

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687)

Signed-off-by: Olga Lavtar <olavtar@redhat.com>

Apply hardware profile to notebook image settings table (opendatahub-io#3645)

* Apply hardware profile to notebook image settings table

* address comment

* add name tooltip for the hardware profile table

* Reuse recommended accelerator annotation for hardware profiles

* Change name resource field to fix layout issues

* fix tests

refractor UsageBar and StorageSizeBar (opendatahub-io#3667)

Hardware Profile Display Name is not trimmed (opendatahub-io#3670)

Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672)

CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685)

* Comitting working tests

* Small wording changes

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants