[RHOAIENG-1141] remove the deprecated nvidia GPU Addon manifest from rhoai #3666
+0
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbravo2
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3666 +/- ##
==========================================
- Coverage 85.15% 84.26% -0.89%
==========================================
Files 1395 1450 +55
Lines 32041 33769 +1728
Branches 8979 9355 +376
==========================================
+ Hits 27284 28455 +1171
- Misses 4757 5314 +557 see 295 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bobbravo2
changed the title
manaswinidas
approved these changes
Jan 22, 2025
aduquett
approved these changes
Jan 22, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aduquett, Gkrumbach07, manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 43d713a
into
opendatahub-io:main
29 checks passed
antowaddle
added a commit
to antowaddle/odh-dashboard
that referenced
this pull request
Jan 29, 2025
…pendatahub-io#3662) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing intermediate changes * Initial changes * Initial changes * Messy working test * Committing working test - not linted/cleaned up * Committing working test with exception of status check on UI * Committing fully working test on RHOAI * Linting fixes * Adding in description for bug relating to manifest links * Actioning PR comments * Comitting initial changes * Comitting working test for Single Model Creation * Comitting final completed test * Small amendment to select model server on ODH * Linting after merge conflict resolution --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> made wording more consistent in storage dialog (opendatahub-io#3665) remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666) Co-authored-by: “Bob <“bgregor@redhat.com”> Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit * Fixed linting * adding package json * Swapped out cypress:run for cypress:e2e --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> Adds required to environment variables (opendatahub-io#3653) * Adds required to environment variables * Accessibility fix Fix for notebook route link font size (opendatahub-io#3678) Update the positions of DW tabs (opendatahub-io#3677) Add default deployment mode selector as read only (opendatahub-io#3664) * Add default deployment mode selector read only * Use DashboardHelpTooltip and fix popper width Fix for page header layout when page has long description (opendatahub-io#3679) Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682) feat: remove the NIM tile from Enabled page (opendatahub-io#3663) * feat: remove the NIM tile from Enabled page Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: rename function Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: add space after the here. Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680) * fix: label update for nim from single serving to NVIDIA NIM Serving Enabled Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: fix cypress test Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687) Signed-off-by: Olga Lavtar <olavtar@redhat.com> Apply hardware profile to notebook image settings table (opendatahub-io#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests refractor UsageBar and StorageSizeBar (opendatahub-io#3667) Hardware Profile Display Name is not trimmed (opendatahub-io#3670) Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672) CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685)
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (#3662) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing intermediate changes * Initial changes * Initial changes * Messy working test * Committing working test - not linted/cleaned up * Committing working test with exception of status check on UI * Committing fully working test on RHOAI * Linting fixes * Adding in description for bug relating to manifest links * Actioning PR comments * Comitting initial changes * Comitting working test for Single Model Creation * Comitting final completed test * Small amendment to select model server on ODH * Linting after merge conflict resolution --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> made wording more consistent in storage dialog (#3665) remove deprecated enabled nvidia manifest from rhoai (#3666) Co-authored-by: “Bob <“bgregor@redhat.com”> Add Exclusions to Cypress e2e Nightly Executions (#3671) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit * Fixed linting * adding package json * Swapped out cypress:run for cypress:e2e --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> Adds required to environment variables (#3653) * Adds required to environment variables * Accessibility fix Fix for notebook route link font size (#3678) Update the positions of DW tabs (#3677) Add default deployment mode selector as read only (#3664) * Add default deployment mode selector read only * Use DashboardHelpTooltip and fix popper width Fix for page header layout when page has long description (#3679) Update ownedByDSC to use correct label for checking what is created by operator (#3682) feat: remove the NIM tile from Enabled page (#3663) * feat: remove the NIM tile from Enabled page Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: rename function Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: add space after the here. Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (#3680) * fix: label update for nim from single serving to NVIDIA NIM Serving Enabled Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: fix cypress test Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: move the permissions from the cluster-role to the role yaml file (#3687) Signed-off-by: Olga Lavtar <olavtar@redhat.com> Apply hardware profile to notebook image settings table (#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests refractor UsageBar and StorageSizeBar (#3667) Hardware Profile Display Name is not trimmed (#3670) Name, resource label, tolerations and Node selector fields - Unlimited size string (#3672) CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (#3685) * Comitting working tests * Small wording changes --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>
ashley-o0o
pushed a commit
to ashley-o0o/odh-dashboard
that referenced
this pull request
Feb 7, 2025
…3666) Co-authored-by: “Bob <“bgregor@redhat.com”>
ashley-o0o
pushed a commit
to ashley-o0o/odh-dashboard
that referenced
this pull request
Feb 7, 2025
…hub-io#3696) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (opendatahub-io#3662) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing intermediate changes * Initial changes * Initial changes * Messy working test * Committing working test - not linted/cleaned up * Committing working test with exception of status check on UI * Committing fully working test on RHOAI * Linting fixes * Adding in description for bug relating to manifest links * Actioning PR comments * Comitting initial changes * Comitting working test for Single Model Creation * Comitting final completed test * Small amendment to select model server on ODH * Linting after merge conflict resolution --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> made wording more consistent in storage dialog (opendatahub-io#3665) remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666) Co-authored-by: “Bob <“bgregor@redhat.com”> Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit * Fixed linting * adding package json * Swapped out cypress:run for cypress:e2e --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> Adds required to environment variables (opendatahub-io#3653) * Adds required to environment variables * Accessibility fix Fix for notebook route link font size (opendatahub-io#3678) Update the positions of DW tabs (opendatahub-io#3677) Add default deployment mode selector as read only (opendatahub-io#3664) * Add default deployment mode selector read only * Use DashboardHelpTooltip and fix popper width Fix for page header layout when page has long description (opendatahub-io#3679) Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682) feat: remove the NIM tile from Enabled page (opendatahub-io#3663) * feat: remove the NIM tile from Enabled page Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: rename function Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: add space after the here. Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680) * fix: label update for nim from single serving to NVIDIA NIM Serving Enabled Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: fix cypress test Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687) Signed-off-by: Olga Lavtar <olavtar@redhat.com> Apply hardware profile to notebook image settings table (opendatahub-io#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests refractor UsageBar and StorageSizeBar (opendatahub-io#3667) Hardware Profile Display Name is not trimmed (opendatahub-io#3670) Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672) CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685) * Comitting working tests * Small wording changes --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>
ugiordan
pushed a commit
to ugiordan/odh-dashboard
that referenced
this pull request
Feb 10, 2025
…hub-io#3696) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Cypress e2e Test - Admin Model Serving (Multi & Single Model) Tests (opendatahub-io#3662) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing intermediate changes * Initial changes * Initial changes * Messy working test * Committing working test - not linted/cleaned up * Committing working test with exception of status check on UI * Committing fully working test on RHOAI * Linting fixes * Adding in description for bug relating to manifest links * Actioning PR comments * Comitting initial changes * Comitting working test for Single Model Creation * Comitting final completed test * Small amendment to select model server on ODH * Linting after merge conflict resolution --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> made wording more consistent in storage dialog (opendatahub-io#3665) remove deprecated enabled nvidia manifest from rhoai (opendatahub-io#3666) Co-authored-by: “Bob <“bgregor@redhat.com”> Add Exclusions to Cypress e2e Nightly Executions (opendatahub-io#3671) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit * Fixed linting * adding package json * Swapped out cypress:run for cypress:e2e --------- Co-authored-by: Fede Alonso <fealonso@redhat.com> Adds required to environment variables (opendatahub-io#3653) * Adds required to environment variables * Accessibility fix Fix for notebook route link font size (opendatahub-io#3678) Update the positions of DW tabs (opendatahub-io#3677) Add default deployment mode selector as read only (opendatahub-io#3664) * Add default deployment mode selector read only * Use DashboardHelpTooltip and fix popper width Fix for page header layout when page has long description (opendatahub-io#3679) Update ownedByDSC to use correct label for checking what is created by operator (opendatahub-io#3682) feat: remove the NIM tile from Enabled page (opendatahub-io#3663) * feat: remove the NIM tile from Enabled page Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: rename function Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: add space after the here. Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: label update for nim project from single serving to NVIDIA NIM Serving Enabled (opendatahub-io#3680) * fix: label update for nim from single serving to NVIDIA NIM Serving Enabled Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: label update Signed-off-by: Olga Lavtar <olavtar@redhat.com> * fix: fix cypress test Signed-off-by: Olga Lavtar <olavtar@redhat.com> --------- Signed-off-by: Olga Lavtar <olavtar@redhat.com> fix: move the permissions from the cluster-role to the role yaml file (opendatahub-io#3687) Signed-off-by: Olga Lavtar <olavtar@redhat.com> Apply hardware profile to notebook image settings table (opendatahub-io#3645) * Apply hardware profile to notebook image settings table * address comment * add name tooltip for the hardware profile table * Reuse recommended accelerator annotation for hardware profiles * Change name resource field to fix layout issues * fix tests refractor UsageBar and StorageSizeBar (opendatahub-io#3667) Hardware Profile Display Name is not trimmed (opendatahub-io#3670) Name, resource label, tolerations and Node selector fields - Unlimited size string (opendatahub-io#3672) CVE-2025-22150 odh-dashboard-container: Undici Uses Insufficiently Random Values [main] (opendatahub-io#3685) * Comitting working tests * Small wording changes --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-1141
Description
See the comments in the Jira story for how we uncovered that this is deprecated and safe to remove.
Support link re: this operator is no longer supported.
How Has This Been Tested?
wget https://raw.githubusercontent.com/opendatahub-io/odh-dashboard/81fc54e3d4a3068289c0dc7f54b1d56070418e37/manifests/rhoai/addon/apps/nvidia/nvidia-app.yamlCreate a new
OdhApplicationin the cluster with the modified payload. Validated that theenabledbutton no longer appearTest Impact
-- The
enablebutton for theNVIDIA GPU addonin RHOAI should no longer be displayed.Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main