Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline logs are not appearing on run details page #3697

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented Jan 29, 2025

RHOAIENG-18916

Description

Pipeline logs were not appearing due to height and position issues. Added a height of 100vh for visibility.

Screenshot 2025-01-29 at 6 44 22 PM

How Has This Been Tested?

Run a pipeline and check its logs.

Test Impact

Improved existing test to verify pipeline logs actually is visible to the user.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jgarciao
Copy link

Could you add a test (in this or a follow-up PR) to detect this bug?

@pnaik1
Copy link
Contributor

pnaik1 commented Jan 30, 2025

I see the height of log viewer overflows the tab

Screen.Recording.2025-01-30.at.4.20.40.PM.mov

Can we smaller height ??

@dpanshug
Copy link
Contributor Author

I see the height of log viewer overflows the tab

@pnaik1 i have smaller the height to 50vh

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.12%. Comparing base (2e6e823) to head (4993a1b).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3697      +/-   ##
==========================================
- Coverage   84.15%   84.12%   -0.03%     
==========================================
  Files        1453     1453              
  Lines       33865    33866       +1     
  Branches     9384     9384              
==========================================
- Hits        28499    28491       -8     
- Misses       5366     5375       +9     
Files with missing lines Coverage Δ
...t/pipelinesDetails/pipelineRun/runLogs/LogsTab.tsx 76.66% <ø> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6e823...4993a1b. Read the comment docs.

@rsun19
Copy link
Contributor

rsun19 commented Jan 30, 2025

/lgtm

code looks good and works on my machine

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

bottom is fixed

Screenshot 2025-01-30 at 2 02 53 PM

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 409d0ef into opendatahub-io:main Jan 30, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants