-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline logs are not appearing on run details page #3697
Pipeline logs are not appearing on run details page #3697
Conversation
Could you add a test (in this or a follow-up PR) to detect this bug? |
I see the height of log viewer overflows the tab Screen.Recording.2025-01-30.at.4.20.40.PM.movCan we smaller height ?? |
56b78a7
to
c020b08
Compare
@pnaik1 i have smaller the height to 50vh |
c020b08
to
4993a1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3697 +/- ##
==========================================
- Coverage 84.15% 84.12% -0.03%
==========================================
Files 1453 1453
Lines 33865 33866 +1
Branches 9384 9384
==========================================
- Hits 28499 28491 -8
- Misses 5366 5375 +9
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/lgtm code looks good and works on my machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
409d0ef
into
opendatahub-io:main
RHOAIENG-18916
Description
Pipeline logs were not appearing due to height and position issues. Added a height of 100vh for visibility.
How Has This Been Tested?
Run a pipeline and check its logs.
Test Impact
Improved existing test to verify pipeline logs actually is visible to the user.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main