Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline logs are not appearing on run details page #3697

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Pipeline logs are not appearing on run details page #3697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelinesTopology.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,9 +682,15 @@ describe('Pipeline topology', () => {

pipelineRunDetails
.findLogs()
.should('be.visible')
.contains(
'sample log for namespace test-project, pod name iris-training-pipeline-v4zp7-2757091352 and for step step-main',
);
)
.and(($el) => {
expect($el.width()).to.be.greaterThan(0);
expect($el.height()).to.be.greaterThan(0);
});

// test whether single step logs download dropdown item is enabled when logs are available
pipelineRunDetails.findDownloadStepsToggle().click();
pipelineRunDetails.findCurrentStepLogs().should('not.be.disabled');
Expand Down
9 changes: 8 additions & 1 deletion frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/runLogs/LogsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,14 @@ const LogsTab: React.FC<LogsTabProps> = ({ task, isCached }) => {
</StackItem>
<StackItem isFilled id="dashboard-logviewer" style={{ position: 'relative' }}>
<div
style={{ position: 'absolute', left: 0, right: 0, top: 0, bottom: 0 }}
style={{
position: 'absolute',
left: 0,
right: 0,
top: 0,
bottom: 0,
height: '50vh',
}}
ref={logsTabRef}
>
<DashboardLogViewer
Expand Down
Loading