[RHOAIENG-11527] - [backend] Incorrect values for number of requests … #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,21 +15,23 @@ limitations under the License. | |||
|
|
|||
| package constants | |||
|
|
|||
| // ${DASHBOARD_RATE_INTERVAL} is a placeholder for the metrics that needs to receive values from the dashboard at the | |||
There was a problem hiding this comment.
This should be ${REQUEST_RATE_INTERVAL}?
There was a problem hiding this comment.
actually this comment needs to be removed, thanks for the heads up.
…in Kserve Performance metrics Signed-off-by: Spolti <fspolti@redhat.com>
israel-hdez
approved these changes
Aug 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spolti
added a commit
to spolti/odh-model-controller
that referenced
this pull request
Aug 27, 2024
…in Kserve Performance metrics (opendatahub-io#256) Signed-off-by: Spolti <fspolti@redhat.com>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in Kserve Performance metrics
A summarized decision:
Description
How Has This Been Tested?
Merge criteria: