Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick https://github.com/opendatahub-io/odh-model-controller/pull/256 #261

Merged

Conversation

spolti
Copy link
Member

@spolti spolti commented Aug 27, 2024

…in Kserve Performance metrics (#256)

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…in Kserve Performance metrics (opendatahub-io#256)

Signed-off-by: Spolti <fspolti@redhat.com>
@Jooho
Copy link
Contributor

Jooho commented Aug 27, 2024

I didn't test this but from the source perspective, it looks good to me. How do we test this?

@Jooho
Copy link
Contributor

Jooho commented Aug 27, 2024

for now, we can move forward but for next time, we should think of integrating some verification process with PRs.

Copy link
Contributor

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 47913e4 into opendatahub-io:release-0.12.0 Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants