[CI/Build] Dockerfile.ubi : Remove test stage #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "test" stage from Dockerfile.ubi was removed to allow for the openshift-ci builds to run. For an unknown reason the "test" stage fails to build in openshift-ci, which uses a custom docker build process.
|
Agreed, this test stage possibly only was used to test installing vllm, but it should not be needed once we build the wheel directly. |
dtrifiro
approved these changes
Apr 26, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dtrifiro, z103cb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
dtrifiro
pushed a commit
that referenced
this pull request
Jul 26, 2024
This PR adds a new TGIS specific readme with some docs about what this repo is, the diffs it contains from vLLM, and instructions on how to manage our contributions. --------- Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "test" stage from Dockerfile.ubi was removed to allow for the openshift-ci builds to run. For an unknown reason the "test" stage fails to build in openshift-ci, which uses a custom docker build process.
The changes were manually tested using build / Podman on RHEL9 machine