doc(zjow): polish ding model common/template note #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ding_model_common_polish
PaParaZz1
requested changes
Oct 27, 2023
| @@ -91,7 +91,7 @@ def __init__( | |||
| ) | |||
|
|
|||
| def forward(self, inputs: Union[torch.Tensor, Dict], mode: str) -> Dict: | |||
| r""" | |||
| """ | |||
There was a problem hiding this comment.
You need to polish maqac with comparsion to qac
…_ding_model_common_polish
PaParaZz1
approved these changes
Nov 1, 2023
puyuan1996
pushed a commit
to puyuan1996/DI-engine
that referenced
this pull request
Nov 1, 2023
* polish ding.model.template * polish code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.