Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

filter out exceptions which should not be counted in failure stats #341

Merged

Conversation

ylwu-amzn
Copy link
Contributor

Issue #, if available:

Description of changes:

  1. Catch wrong feature query exception and stop detector
  2. Some exceptions are caused by customer input, which not related with the code logic. Will filter out such exceptions so we can get the failure stats which caused by server error.

Test

  1. ./gradlew build
  2. ./gradlew integTest -PnumNodes=3
  3. Start local cluster and test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #341 (e204a1c) into master (2ae77ed) will increase coverage by 0.53%.
The diff coverage is 65.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #341      +/-   ##
============================================
+ Coverage     75.50%   76.03%   +0.53%     
- Complexity     2160     2224      +64     
============================================
  Files           207      209       +2     
  Lines         10030    10179     +149     
  Branches        898      906       +8     
============================================
+ Hits           7573     7740     +167     
+ Misses         2035     2016      -19     
- Partials        422      423       +1     
Flag Coverage Δ Complexity Δ
cli 79.27% <ø> (ø) 0.00 <ø> (ø)
plugin 75.79% <65.85%> (+0.58%) 0.00 <11.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...pendistroforelasticsearch/ad/NodeStateManager.java 69.60% <0.00%> (-1.40%) 29.00 <0.00> (ø)
.../handler/IndexAnomalyDetectorJobActionHandler.java 10.58% <0.00%> (-0.26%) 3.00 <0.00> (ø)
...rch/ad/transport/AnomalyResultTransportAction.java 80.83% <68.75%> (+0.02%) 77.00 <5.00> (+6.00)
...ad/common/exception/AnomalyDetectionException.java 91.66% <75.00%> (-8.34%) 5.00 <3.00> (ø)
...ticsearch/ad/common/exception/ClientException.java 100.00% <100.00%> (ø) 4.00 <1.00> (+1.00)
...ticsearch/ad/common/exception/EndRunException.java 100.00% <100.00%> (ø) 4.00 <1.00> (+1.00)
...ch/ad/common/exception/LimitExceededException.java 100.00% <100.00%> (ø) 3.00 <0.00> (+1.00)
...ad/common/exception/ResourceNotFoundException.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...oforelasticsearch/ad/feature/SearchFeatureDao.java 85.00% <100.00%> (+4.49%) 86.00 <1.00> (+5.00)
...sticsearch/ad/indices/AnomalyDetectionIndices.java 49.34% <0.00%> (-0.33%) 40.00% <0.00%> (ø%)
... and 12 more

@ylwu-amzn ylwu-amzn linked an issue Dec 24, 2020 that may be closed by this pull request
@ylwu-amzn ylwu-amzn added the enhancement New feature or request label Dec 24, 2020
@ylwu-amzn ylwu-amzn linked an issue Dec 24, 2020 that may be closed by this pull request
Copy link
Contributor

@yizheliu-amazon yizheliu-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no major concerns

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out non-server error in AD failure stats
3 participants