Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

backport change: filter out exceptions which should not be counted in failure stats #347

Conversation

ylwu-amzn
Copy link
Contributor

Issue #, if available:

Backport this change: #341

Description of changes:

  1. Catch wrong feature query exception and stop detector
  2. Some exceptions are caused by customer input, which not related with the code logic. Will filter out such exceptions so we can get the failure stats which caused by server error.

Test

  1. ./gradlew build
  2. ./gradlew integTest -PnumNodes=3
  3. Start local cluster and test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (opendistro-1.11@5d30bb9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             opendistro-1.11     #347   +/-   ##
==================================================
  Coverage                   ?   73.01%           
  Complexity                 ?     2026           
==================================================
  Files                      ?      201           
  Lines                      ?     9600           
  Branches                   ?      854           
==================================================
  Hits                       ?     7009           
  Misses                     ?     2180           
  Partials                   ?      411           
Flag Coverage Δ Complexity Δ
cli 79.27% <0.00%> (?) 0.00% <0.00%> (?%)
plugin 72.50% <0.00%> (?) 0.00% <0.00%> (?%)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ylwu-amzn ylwu-amzn changed the title filter out exceptions which should not be counted in failure stats backport change: filter out exceptions which should not be counted in failure stats Dec 29, 2020
@ylwu-amzn ylwu-amzn merged commit 11dfbf1 into opendistro-for-elasticsearch:opendistro-1.11 Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants