feat(topology): add affinity key to core #812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhaashish
force-pushed
the
affinity
branch
2 times, most recently
from
7a2b786
to
b613642
Compare
| @@ -118,6 +122,103 @@ impl Deref for GetSuitablePools { | |||
| } | |||
| } | |||
|
|
|||
| /// Create replicas of a volume. | |||
| /// Selects the best pool candidates to create lvol replicas on. | |||
There was a problem hiding this comment.
Suggested change
| /// Selects the best pool candidates to create lvol replicas on. | |
| /// Selects the best pool candidates to create volume replicas on. |
| @@ -118,6 +122,103 @@ impl Deref for GetSuitablePools { | |||
| } | |||
| } | |||
|
|
|||
| /// Create replicas of a volume. | |||
| /// Selects the best pool candidates to create lvol replicas on. | |||
| pub(crate) struct CreateVolumeReplica { | |||
There was a problem hiding this comment.
Why do we need a new type? Moreover it's quite similar to AddVolumeReplicas
| @@ -64,6 +64,8 @@ message PoolState { | |||
| uint64 used = 6; | |||
| // total size of pool replicas | |||
| optional uint64 committed = 7; | |||
| // optional labels of pool | |||
There was a problem hiding this comment.
hmm this doesn't make sense? Dataplane pool state has no notion of labels...
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
| @@ -15,9 +15,10 @@ use crate::{ | |||
| node::wrapper::NodeWrapper, | |||
| }; | |||
| use agents::errors::{NotEnough, SvcError}; | |||
| use std::collections::HashMap; | |||
There was a problem hiding this comment.
Please move this down after a blank line.
|
PR #846 raised for the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.