Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(topology): add pool affinity key #846

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat(topology): add pool affinity key #846

wants to merge 5 commits into from

Conversation

sinhaashish
Copy link
Member

No description provided.

@sinhaashish sinhaashish mentioned this pull request Jun 25, 2024
Closed
tiagolobocastro
tiagolobocastro reviewed Jun 27, 2024
View reviewed changes
control-plane/agents/src/bin/core/controller/resources/mod.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/clone_operations.rs Outdated Show resolved Hide resolved
control-plane/grpc/src/operations/replica/traits.rs Outdated Show resolved Hide resolved
tests/bdd/features/volume/topology/test_pool_topology.py Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/controller/scheduling/volume_policy/mod.rs Show resolved Hide resolved
control-plane/agents/src/bin/core/controller/scheduling/volume_policy/mod.rs Show resolved Hide resolved
control-plane/agents/src/bin/core/pool/wrapper.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
@sinhaashish sinhaashish changed the title Pool affinity key feat(topology): add pool affinity key Jun 27, 2024
tiagolobocastro
tiagolobocastro reviewed Jul 4, 2024
View reviewed changes
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/scheduling.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/scheduling.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/scheduling.rs Show resolved Hide resolved
tiagolobocastro
tiagolobocastro reviewed Jul 9, 2024
View reviewed changes
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/operations.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/scheduling.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/volume/specs.rs Outdated Show resolved Hide resolved
@sinhaashish sinhaashish force-pushed the pool-affinity-key branch 2 times, most recently from 328735c to 22fa137 Compare July 17, 2024 08:16
@sinhaashish
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jul 19, 2024
@sinhaashish
chore(bors): merge pull request #846
9785017 
846: feat(topology): add pool affinity key r=sinhaashish a=sinhaashish



Co-authored-by: sinhaashish <ashi.sinha.87@gmail.com>
@bors-openebs-mayastor
Copy link

Build failed:

@sinhaashish
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jul 19, 2024
@sinhaashish
chore(bors): merge pull request #846
915f6bb 
846: feat(topology): add pool affinity key r=sinhaashish a=sinhaashish



Co-authored-by: sinhaashish <ashi.sinha.87@gmail.com>
@bors-openebs-mayastor
Copy link

Build failed:

@sinhaashish
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jul 19, 2024
@sinhaashish
chore(bors): merge pull request #846
180c146 
846: feat(topology): add pool affinity key r=sinhaashish a=sinhaashish



Co-authored-by: sinhaashish <ashi.sinha.87@gmail.com>
@bors-openebs-mayastor
Copy link

Build failed:

@sinhaashish
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jul 19, 2024
@sinhaashish
chore(bors): merge pull request #846
4e5dc7a 
846: feat(topology): add pool affinity key r=sinhaashish a=sinhaashish



Co-authored-by: sinhaashish <ashi.sinha.87@gmail.com>
@bors-openebs-mayastor
Copy link

Build failed:

@sinhaashish
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jul 19, 2024
@sinhaashish
chore(bors): merge pull request #846
bd1c1f0 
846: feat(topology): add pool affinity key r=sinhaashish a=sinhaashish



Co-authored-by: sinhaashish <ashi.sinha.87@gmail.com>
@bors-openebs-mayastor
Copy link

Build failed:

@sinhaashish
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jul 19, 2024
@sinhaashish
chore(bors): merge pull request #846
dcb4a8b 
846: feat(topology): add pool affinity key r=sinhaashish a=sinhaashish



Co-authored-by: sinhaashish <ashi.sinha.87@gmail.com>
@bors-openebs-mayastor
Copy link

Build failed:

@sinhaashish
feat(topology/poolaffinitykey): add topology/poolaffinitykey code to …
1885988 
…core

Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
@sinhaashish
feat(topology/poolaffinitykey): add topology/poolaffinitykey code to …
4dda5f9 
…grpc, storport

Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
@sinhaashish
feat(topology/poolaffinitykey): add topology/poolaffinitykey code to …
fce465f 
…rest

Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
@sinhaashish
feat(topology/poolaffinitykey): add topology/poolaffinitykey code to …
7b1e1d4 
…csi-driver

Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
@sinhaashish
feat(topology): add test for pool affinity
6acbc2a 
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
@sinhaashish
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 10, 2024
@sinhaashish
chore(bors): merge pull request #846
cd9bbe4 
846: feat(topology): add pool affinity key r=sinhaashish a=sinhaashish



Co-authored-by: sinhaashish <ashi.sinha.87@gmail.com>
@bors-openebs-mayastor
Copy link

Build failed:

@tiagolobocastro
Copy link
Contributor

Had a look at this and I found the problem but the fact that this has taken so long is making me wonder if we've got things a bit too complicated here.
Was kinda difficult to navigate the code and figure out what's going on.
Let's close this PR, raise api changes only and let's get those merged in first.
Then we can try the implementation again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinhaashish @tiagolobocastro @Abhinandan-Purkait