Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Convert to OAuth2 login provider instead of OIDC#38

Merged
bradenmacdonald merged 1 commit intomasterfrom
oauth2-sso
Jun 18, 2019
Merged

Convert to OAuth2 login provider instead of OIDC#38
bradenmacdonald merged 1 commit intomasterfrom
oauth2-sso

Conversation

@bradenmacdonald
Copy link
Contributor

@bradenmacdonald bradenmacdonald commented May 19, 2019

This changes our use of auth-backends from the deprecated OIDC provider to the OAuth2 provider, because I rebuilt my devstack and the OIDC one wasn't working.

This is working, however there are a couple issues:

  • Superuser permission doesn't seem to be applied via SSO - when I login as a user who has staff and superuser permissions, the blockstore user only has staff permission
    • perhaps related to this but I think I had that fix?
  • The OAuth2 backend by default requests the user_id scope, and based on these two PRs, that should work, but the default devstack LMS is giving me an invalid_scope error when user_id is included. Not sure why.

Test instructions: See the instructions added to the README.

Copy link
Collaborator

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the answer to your questions, but I'm definitely happy to merge this as is and worry about those issues later.

@bradenmacdonald
Copy link
Contributor Author

Thanks @ormsbee!

@bradenmacdonald bradenmacdonald merged commit 94c3a1d into master Jun 18, 2019
@bradenmacdonald bradenmacdonald deleted the oauth2-sso branch June 18, 2019 23:05
@bradenmacdonald
Copy link
Contributor Author

@robrap Would you happen to know the default devstack LMS is giving an invalid_scope error when our IDA tries to use the OAuth2 SSO flow and requests the user_id scope from the LMS? (i.e. why edx-auth-backends does not work out of the box, unless I override it to not request that scope?)

I'm guessing it relates to https://github.com/edx/auth-backends/pull/59 and https://github.com/edx/edx-platform/pull/20057 but I definitely have both of those PRs merged in the branches I'm using for edx-auth-backends and for the LMS.

@robrap
Copy link

robrap commented Jun 19, 2019

I forwarded an email that should help. Let me know if you still have problems.

@robrap
Copy link

robrap commented Jun 19, 2019

FYI: @nasthagiri: another instance of trouble for someone unless and until we swap the default scopes.

@bradenmacdonald
Copy link
Contributor Author

Ah, thanks so much @robrap :) That was the missing info I needed. Everything is working well now.

@openedx-webhooks openedx-webhooks added merged open-source-contribution PR author is not from Axim or 2U labels Jan 22, 2021
@openedx-webhooks
Copy link

Although this pull request is already merged, I've created OSPR-5450 so that we can track it in Jira.

There is nothing you have to do. No action is needed from your side. Thanks again for your contribution.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U and removed open-source-contribution PR author is not from Axim or 2U labels Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants