This repository was archived by the owner on May 14, 2024. It is now read-only.
Properly fetch user_id during LMS SSO flow#41
Merged
bradenmacdonald merged 1 commit intomasterfrom Jun 20, 2019
Merged
Conversation
bradenmacdonald
commented
Jun 20, 2019
| #. Check "Skip authorization" | ||
| #. Press "Save and continue editing" | ||
| #. Go to http://localhost:18000/admin/oauth_dispatch/applicationaccess/ | ||
| #. Click "Add Application Access +", choose Application: ``blockstore-sso`` and set Scopes to ``user_id``, then hit "Save" |
Contributor
Author
There was a problem hiding this comment.
^ The above two steps are the new ones
Contributor
Author
|
@ormsbee Do you have a minute to look at this? |
ormsbee
approved these changes
Jun 20, 2019
openedx-webhooks
added
merged
open-source-contribution
|
Although this pull request is already merged, I've created OSPR-5448 so that we can track it in Jira. There is nothing you have to do. No action is needed from your side. Thanks again for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a quick follow-up to #38, to remove a workaround now that I know what settings on the LMS must be changed for the SSO flow to work as intended.
Author Comments, Concerns, and Open Questions
Test Instructions
Check out this branch and restart Blockstore. Configure your devstack per the updated README instructions in this PR, then login to Blockstore by going to http://localhost:18250/login in an incognito window.
Then go to http://localhost:18250/admin/social_django/usersocialauth/ and click on the user you used (e.g. "staff") and confirm that the user_id is present in the "Extra Data" JSON field.