Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Add PROSPECTUS_ALGOLIA_ADMIN_KEY to environment #6780

Merged

Conversation

kalebjdavenport
Copy link
Contributor

This change allows future builds using the PROSPECTUS_ALGOLIA_ADMIN_KEY to build properly using updated key name

Configuration Pull Request

Make sure that the following steps are done before merging:

  • A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 6, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @TheEarlyNerd! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

@kalebjdavenport kalebjdavenport force-pushed the TheEarlyNerd/add-environment-variable-algolia-admin branch 2 times, most recently from 5f8369e to e027c14 Compare July 7, 2022 13:25
This change allows future builds using the PROSPECTUS_ALGOLIA_ADMIN_KEY to build properly using updated key name
@kalebjdavenport kalebjdavenport force-pushed the TheEarlyNerd/add-environment-variable-algolia-admin branch from e027c14 to 64e5f67 Compare July 7, 2022 14:37
@kalebjdavenport kalebjdavenport merged commit 9d2ebd1 into master Jul 7, 2022
@kalebjdavenport kalebjdavenport deleted the TheEarlyNerd/add-environment-variable-algolia-admin branch July 7, 2022 14:42
@openedx-webhooks
Copy link

@TheEarlyNerd 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants