This repository was archived by the owner on Nov 4, 2024. It is now read-only.
Update LMSPublisher to not convert price to integer#3316
Closed
julianajlk wants to merge 1 commit intomasterfrom
Closed
Update LMSPublisher to not convert price to integer#3316julianajlk wants to merge 1 commit intomasterfrom
julianajlk wants to merge 1 commit intomasterfrom
Conversation
77c892a to
57ed0f1
Compare
57ed0f1 to
d874fc3
Compare
…ng LMS handle the conversion
d874fc3 to
1f29582
Compare
Contributor
Author
|
Closing as this work was reprioritized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REV-1632.
Background:
The
min_pricecolumn in LMSCourseModetable takes integers, and should be updated to take decimals to match the price in ecommerce database, making the price across the learner pathway to purchase the same (49.99 vs. 49).This ticket covers:
Currently, ecommerce serializes the price as an
intbefore sending a request to LMS - this ticket removes this conversion so that it's converted to a float instead, keeping the digits, then LMS will handle the conversion to the appropriate type it needs in theCourseModetable.In order to decrease the risk of breaking anything with migrations, this change will be divided into 5 steps across edx-platform and ecommerce:
min_pricecan receive non-int.LMSPublisherto stop convertingmin_priceto int.min_price, and thatmin_pricecan receive a Decimal.min_pricecolumn.