Conversation
712d068 to
38529d2
Compare
38529d2 to
c080e85
Compare
c080e85 to
2e5fb79
Compare
|
Your PR has finished running tests. The following contexts failed:
|
|
📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to avoid breaking the build. We recently removed diff-quality and introduced lint-amnesty. This means that the automated quality check that has run on your branch doesn't work the same way it will on master. If you have introduced any quality failures, they might pass on the PR but then break the build on master. This branch has been detected to not have commit 2e33565 as an ancestor. Here's how to see for yourself: If you have any questions, please reach out to the Architecture team (either #edx-shared-architecture on Open edX Slack or #architecture on edX internal). |
|
Closing as this work was reprioritized. |
REV-1632.
Background:
The
min_pricecolumn in LMSCourseModetable takes integers, and should be updated to take decimals to match the price in ecommerce database, making the price across the learner pathway to purchase the same (49.99 vs. 49).This ticket covers:
Before (2) is deployed in ecommerce, LMS must be able to handle receiving the price data as a non-integer. Originally had this check before
.save()inCourseModemodel, but per Emma's point, would be better to check this earlier - now inCourseRetrieveUpdateView(urls.py uses this view) forcommerce API.In order to decrease the risk of breaking anything with migrations, this change will be divided into 5 steps across edx-platform and ecommerce:
min_pricecan receive non-int.min_pricevalue.min_pricecolumn.