Skip to content
This repository was archived by the owner on Mar 20, 2025. It is now read-only.

nutmeg release notes#2056

Merged
pdpinch merged 52 commits intoopenedx-unsupported:masterfrom
mitodl:pdpinch/nutmeg-release-notes
Jun 9, 2022
Merged

nutmeg release notes#2056
pdpinch merged 52 commits intoopenedx-unsupported:masterfrom
mitodl:pdpinch/nutmeg-release-notes

Conversation

@pdpinch
Copy link
Contributor

@pdpinch pdpinch commented Apr 18, 2022

Nutmeg release notes.

part of openedx/wg-build-test-release#133

Date Needed (optional)

Nutmeg will be released on June 9, 2022

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

  • Subject matter expert: @sarina
  • Subject matter expert: @feanil
  • Subject matter expert: @nedbat
  • Subject matter expert: @kdmccormick
  • Doc team review (sanity check, copy edit, or dev edit?): @edx/doc
  • Product review: @jmakowski1123
  • PM review: n/a

@briangrossman @blarghmatey @shaidar

Testing

  • Ran ./run_tests.sh without warnings or errors

HTML Version (optional)

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Apr 18, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 18, 2022

Thanks for the pull request, @pdpinch! I've created OSPR-6627 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@pdpinch
Copy link
Contributor Author

pdpinch commented Apr 18, 2022

This is a very rough first pass. I have a couple of preliminary questions:

  • Am I targeting the right branch?
  • Will I get a readthedocs build?
  • Does the basic structure make sense?

@pdpinch pdpinch force-pushed the pdpinch/nutmeg-release-notes branch from 0103d19 to 5634976 Compare April 18, 2022 20:08
@nedbat
Copy link
Contributor

nedbat commented Apr 18, 2022

@pdpinch It is amazing to have this happening so early in the process! A definite improvement over previous releases.

This is the section of the process about documentation: https://openedx.atlassian.net/wiki/spaces/COMM/pages/19662426/Process+to+Create+an+Open+edX+Release#Documentation

It says the release notes should be made on the master branch, and cherry-picked over to Nutmeg, so this should be a PR against master. This has the advantage of giving you a RTFD build.

@pdpinch pdpinch changed the base branch from open-release/nutmeg.master to master April 18, 2022 20:46
@pdpinch
Copy link
Contributor Author

pdpinch commented Apr 20, 2022

@nedbat do you know why the github action is building edx-developer-guide and not open-edx-release-notes? Can I change what's built, or add to it?

@pdpinch pdpinch marked this pull request as draft April 20, 2022 12:29
@pdpinch
Copy link
Contributor Author

pdpinch commented Apr 21, 2022

Huh, I thought "squash" was an allowed commit message.

@pdpinch pdpinch force-pushed the pdpinch/nutmeg-release-notes branch from 0cadb95 to be682d6 Compare April 21, 2022 16:35
@nedbat
Copy link
Contributor

nedbat commented Apr 21, 2022

@pdpinch it looks like the action does build the release notes: https://github.com/openedx/edx-documentation/runs/6115943991?check_suite_focus=true#step:6:2510 What makes you say it doesn't?

Oh: you mean it's not built on ReadTheDocs.... I'll look into that.

@nedbat
Copy link
Contributor

nedbat commented Apr 21, 2022

I enabled pull request builds on ReadTheDocs for the release notes. It's a setting in the Advanced Settings for the project.

@nedbat nedbat closed this Apr 21, 2022
@nedbat nedbat reopened this Apr 21, 2022
@openedx-webhooks
Copy link

Hello @pdpinch: We are unable to continue with review of your submission at this time. Please see the associated JIRA ticket for more explanation.

@openedx-webhooks openedx-webhooks added rejected and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Apr 21, 2022
@nedbat nedbat reopened this Apr 21, 2022
@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed rejected labels Apr 21, 2022
@pdpinch
Copy link
Contributor Author

pdpinch commented Apr 21, 2022

Thanks to @nedbat we now have a RTD build of this WIP PR: https://edx--2056.org.readthedocs.build/projects/open-edx-release-notes/en/2056/ (I also added a link to the description)

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdpinch added some comments around "experimental" MFEs, which is too generous a term for where they're actually at.

Authentication Micro-Frontend (MFE)
-----------------------------------

The `Authentication Micro-Frontend (MFE)`_ is available as an experimental feature, but is not yet supported in Tutor. It will be supported in the next release, Olive.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdpinch could we move all the experimental features under one section, and also call them pre-alpha? Experimental to me implies there's a flag or setting that will turn them on. Beta even sounds more complete than where we're currently at. Enabling one of these MFEs would take a lot of work and it's undocumented. I recommend this structure:

Pre-Alpha Features
-------------------

The following Micro-frontends (MFEs) are in a "pre-alpha" state. They exist on GitHub but are not yet supported in Tutor. Additionally, they may lack key features such as support for theming, internationalization, and path-based deployments. We include mention of them because we expect all of them to be supported in the next release, Olive.

* `Authentication Micro-Frontend (MFE)`_
* `Discussions Micro-Frontend (MFE)`_
* `Course Authoring Micro-frontend (MFE)`_

.. _Authentication Micro-Frontend: https://github.com/openedx/frontend-app-authn
.. _Discussions Micro-Frontend (MFE): https://github.com/openedx/frontend-app-discussions
.. Course Authoring Micro-frontend (MFE): TBD

and please put this sub-section at the very bottom of this section (ie under Special Exams).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this approach, but I don't think they all belong within "Learner Experiences."

Given the challenge of enabling them, I put this at the end of the "Administrators & Operators" section.

@pdpinch pdpinch force-pushed the pdpinch/nutmeg-release-notes branch from ac058f1 to f9b795a Compare June 9, 2022 04:22

* Various improvements and bugfixes have been applied to `Tutor`_, the officialy-supported Open edX distribution and installation method. Notable features include an overhauled Tutor Plugin API and a new CLI for mounting repositories during development. You can see the full list by viewing `Tutor's changelog, starting at v13.0.1`_ (the first Tutor release after Maple) and reading upwards until v14.0.0 (the first Tutor release supporting Nutmeg).

.. _Tutor's changelog, starting at v13.0.1: https://github.com/overhangio/tutor/blob/master/CHANGELOG.md#v1301-2021-12-20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdmccormick @regisb is this Ok? Or do you want to suggest more details?

@pdpinch
Copy link
Contributor Author

pdpinch commented Jun 9, 2022

I think this is ready to merge for the release. Let me know if/when I should squash the commits.

@ghassanmas
Copy link
Contributor

There was the latest merge in nutmeg.master yesterday it resolved a minor bug. _ it fixes facebook sharing button in course about page_. for more context check test: openedx/wg-build-test-release/issues/174 PR: openedx/openedx-platform/pull/30518

@regisb
Copy link
Contributor

regisb commented Jun 9, 2022

I think this is ready to merge for the release. Let me know if/when I should squash the commits.

I think you should! Though I'm not quite sure how the docs are handled and at what point they get deployed to readthedocs.

@kdmccormick
Copy link
Contributor

kdmccormick commented Jun 9, 2022

too many teams that sound like the "release" team: https://github.com/orgs/openedx/teams?query=release

Whoops, wrong issue.

@pdpinch pdpinch merged commit 6364380 into openedx-unsupported:master Jun 9, 2022
@openedx-webhooks
Copy link

@pdpinch 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

nedbat pushed a commit that referenced this pull request Jun 9, 2022
* docs: add info from wiki

* docs: add changes to settings & feature toggles

* docs: add deprecation details

* docs: Account MFE is default; legacy account pages are deprecated

* docs: authn, discussions MFE are pre-alpha

* docs: course authoring MFE & Zoom are experimental in nutmeg

* docs: ORA Grading MFE is experimental

Co-authored-by: Feanil Patel <feanil@tcril.org>

(cherry picked from commit 6364380)
@nedbat
Copy link
Contributor

nedbat commented Jun 9, 2022

I've cherry-picked this (as commit 6364380) onto the Nutmeg branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants