Skip to content

fix: share urls in course about page (#30389)#30518

Merged
giovannicimolin merged 1 commit intoopenedx:open-release/nutmeg.masterfrom
ghassanmas:fix-url-share
Jun 8, 2022
Merged

fix: share urls in course about page (#30389)#30518
giovannicimolin merged 1 commit intoopenedx:open-release/nutmeg.masterfrom
ghassanmas:fix-url-share

Conversation

@ghassanmas
Copy link
Member

This is just backporting for #30389, that shall fix openedx/wg-build-test-release#174.

@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! I've created OSPR-6749 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jun 1, 2022
@natabene
Copy link
Contributor

natabene commented Jun 1, 2022

@ghassanmas Thank you, is this ready for a review?

@ghassanmas
Copy link
Member Author

@natabene yes. And for the record I tested this multiple times and the changes could be tested https://edx.gsgapp.io/courses/course-v1:test+DemoX+2324/about

@regisb
Copy link
Contributor

regisb commented Jun 8, 2022

@openedx/edx-community-bot merge

@giovannicimolin
Copy link
Contributor

Merging this on behalf of @regisb.
This is a backport for Nutmeg.

CC @natabene

@giovannicimolin giovannicimolin merged commit 26d8e98 into openedx:open-release/nutmeg.master Jun 8, 2022
@openedx-webhooks
Copy link

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants