-
Notifications
You must be signed in to change notification settings - Fork 78
Adding description for pending frontend plugin slots #1248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding description for pending frontend plugin slots #1248
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Wow thanks so much for this @jacobo-dominguez-wgu !!!! @brian-smith-tcril do you mind giving this a once-over before I merge it? |
|
These look good! I do have a couple questions about how we want to handle these links:
|
These are the Teak release notes (point-in-time documentation) so we should link to Teak branch.
Yes
Might as well so we can remember to verify that the docs render with clickable links. |
Perfect. I just wanted to confirm since the PRs updating the docs on the repos are going to
Sounds great! @jacobo-dominguez-wgu would you be able to make some backport PRs to get the documentation that's landed into the teak branches?
The PRs to the repos aren't changing the URLs at all, just adding documentation to the barebones READMEs that already exist. |
|
🤦🏻♀️ yes duh, okay then this PR is not blocked on the backport. If the descriptions look good to you go ahead and merge! |
Sure, I will create those backports, thanks! |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Description
Adding descriptions for the pending plugin slots from authoring and learning mfe's.
Since we already created some docs for some plugins slots on their own repos, this should be reflected on the global docs for openEdx.
Dependencies