-
Notifications
You must be signed in to change notification settings - Fork 299
adding comprehensive readme documentation for plugin slots #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding comprehensive readme documentation for plugin slots #1770
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
c840f75 to
ac1c9fe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1770 +/- ##
==========================================
+ Coverage 90.33% 90.38% +0.04%
==========================================
Files 344 344
Lines 5793 5811 +18
Branches 1394 1396 +2
==========================================
+ Hits 5233 5252 +19
+ Misses 541 540 -1
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all this documentation!
* feat: update certificate icons Old certificates icons contained edX trademark logos, which were not suitable for the open source repos. Replaced with icons that contain Open edX logos. * fix(docs): correct CourseRecommendationsSlot README title (openedx#1688) * fix(docs): correct ProgressCertificateStatusSlot README title (openedx#1689) * docs: add comprehensive readme documentation for plugin slots (openedx#1770) --------- Co-authored-by: Maxim Beder <maxim@opencraft.com> Co-authored-by: Brian Smith <112954497+brian-smith-tcril@users.noreply.github.com> Co-authored-by: Jacobo Dominguez <jacobo.dominguez@wgu.edu>
Description
Created docs for pending plugin slots with example code and image.
Content IFrame Loader Slot
Course Outline Tab Notifications Slot
Gated Unit Content Message Slot
Notification Tray Slot
Notification Widget Slot