-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create content in library permission added to API response #34934
Merged
bradenmacdonald
merged 7 commits into
openedx:master
from
open-craft:chris/FAL-3754-permission-in-library
Jun 24, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4e190c3
fix: Comment collection uuid in libraries
ChrisChV a1ee71f
feat: Create content in library permission added to API response
ChrisChV 9fdee28
Merge branch 'master' into chris/FAL-3754-permission-in-library
ChrisChV c303069
refactor: Get edit library permission on serializer
ChrisChV 5f0ecef
style: Fix tests and nits on lint
ChrisChV 8377273
refactor: Delete collection_uuid code.
ChrisChV 2d3cff4
style: Nit on code
ChrisChV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisChV @bradenmacdonald: Did you mean to leave a commented out line of code? Shouldn't it just be deleted?
I only happened to look at this PR because the tests failed on master (at first) due to some issue uploading an artifact, but it passed after I re-ran (or maybe after Braden had)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just an oversight on my part. I should have asked for that line to be deleted during the review. We're doing lots of work in this area though, so we'll remove it in a follow-up pass.