Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create content in library permission added to API response #34934

Merged
merged 7 commits into from
Jun 24, 2024
Merged

feat: Create content in library permission added to API response #34934

merged 7 commits into from
Jun 24, 2024

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Jun 6, 2024 •
edited
Loading

Description

This PR includes this changes:

  • Comment the code that uses collection_uuid to create libraries.
  • Add create content in library permission on library details response.

Supporting information

Testing instructions

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV ChrisChV force-pushed the chris/FAL-3754-permission-in-library branch from 4acbffa to a1ee71f Compare June 6, 2024 18:55
This was referenced Jun 6, 2024
Merged
Closed
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Jun 11, 2024
bradenmacdonald
bradenmacdonald requested changes Jun 13, 2024
View reviewed changes
openedx/core/djangoapps/content_libraries/api.py Outdated Show resolved Hide resolved
openedx/core/djangoapps/content_libraries/api.py Outdated Show resolved Hide resolved
openedx/core/djangoapps/content_libraries/views.py Outdated Show resolved Hide resolved
@ChrisChV ChrisChV force-pushed the chris/FAL-3754-permission-in-library branch from a5c44cc to 5f0ecef Compare June 18, 2024 20:37
rpenido
rpenido approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@rpenido rpenido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 @ChrisChV ! Good work.
I added a nit, but not blocking.

  • I tested this: I followed the testing from the course-authoring PR
  • I read through the code and considered the security, stability and performance implications of the changes.
  • Includes tests for bugfixes and/or features added.

openedx/core/djangoapps/content_libraries/serializers.py Outdated Show resolved Hide resolved
This was referenced Jun 20, 2024
Merged
Closed
@bradenmacdonald bradenmacdonald merged commit 4fd60c4 into openedx:master Jun 24, 2024
48 checks passed
@bradenmacdonald bradenmacdonald deleted the chris/FAL-3754-permission-in-library branch June 24, 2024 19:15
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

robrap
robrap reviewed Jun 24, 2024
View reviewed changes
openedx/core/djangoapps/content_libraries/serializers.py
@@ -34,7 +36,7 @@ class ContentLibraryMetadataSerializer(serializers.Serializer):
org = serializers.SlugField(source="key.org")
slug = serializers.CharField(source="key.slug", validators=(validate_unicode_slug, ))
bundle_uuid = serializers.UUIDField(format='hex_verbose', read_only=True)
collection_uuid = serializers.UUIDField(format='hex_verbose', write_only=True)
#collection_uuid = serializers.UUIDField(format='hex_verbose', write_only=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV @bradenmacdonald: Did you mean to leave a commented out line of code? Shouldn't it just be deleted?

I only happened to look at this PR because the tests failed on master (at first) due to some issue uploading an artifact, but it passed after I re-ran (or maybe after Braden had)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just an oversight on my part. I should have asked for that line to be deleted during the review. We're doing lots of work in this area though, so we'll remove it in a follow-up pass.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@itsjeyd itsjeyd removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrap robrap robrap left review comments

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

@rpenido rpenido rpenido approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ChrisChV @openedx-webhooks @edx-pipeline-bot @rpenido @bradenmacdonald @robrap @itsjeyd @mphilbrick211