-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0059] feat: Add content sidebar in library home #1065
[FC-0059] feat: Add content sidebar in library home #1065
Conversation
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1065 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 693 693
Lines 12346 12346
Branches 2699 2661 -38
=======================================
Hits 11443 11443
Misses 872 872
Partials 31 31 ☔ View full report in Codecov by Sentry. |
49a8ba7
to
cbceb2e
Compare
cbceb2e
to
a6b5df4
Compare
a298644
to
0ffbf82
Compare
cb93687
to
3c16ddf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice. This is almost there.
@bradenmacdonald It's ready for another review |
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds:
Supporting information
New
button.Testing instructions
New
New
button is disabledSettings
Tutor requirements