Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0059] feat: Add content sidebar in library home #1065

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented May 31, 2024

Description

This PR adds:

  • Library Sidebar with feature of "squash the page"
  • Add new content sidebar.
  • New button, disabled if the user doesn't have permissions

Supporting information

Testing instructions

from openedx.core.djangoapps.content_libraries.models import ContentLibrary
lib = ContentLibrary.objects.all()[0]
lib.allow_public_read = True
lib.save()

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/open-craft/edx-platform.git
EDX_PLATFORM_VERSION: taxonomy-sandbox-20240614

GROVE_REDIRECTS:
 - domain: {{ LMS_HOST }}
 - domain: cms.{{ LMS_HOST }}
 - domain: app.{{ LMS_HOST }}
 - domain: meilsearch.{{ LMS_HOST }}

PLUGINS:
- mfe
- grove
- s3
- meilisearch

Tutor requirements

git+https://github.com/overhangio/tutor.git@nightly
git+https://github.com/overhangio/tutor-discovery.git@nightly
git+https://github.com/overhangio/tutor-ecommerce.git@nightly
git+https://github.com/overhangio/tutor-xqueue.git@nightly
git+https://github.com/overhangio/tutor-forum.git@nightly
git+https://gitlab.com/opencraft/dev/tutor-contrib-grove.git@main

git+https://github.com/open-craft/tutor-mfe.git@7d1e1e0dad2c0e4247a4fd8280c257f13ed28432
git+https://github.com/open-craft/tutor-contrib-s3.git@04c7491442fa231e79840995f1f8707eed6353fd

@ChrisChV ChrisChV requested a review from a team as a code owner May 31, 2024 22:59
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 31, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (e087001) to head (3f39d6a).
Report is 667 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1065   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files         693      693           
  Lines       12346    12346           
  Branches     2699     2661   -38     
=======================================
  Hits        11443    11443           
  Misses        872      872           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisChV ChrisChV force-pushed the chris/FAL-3754-library-home-create-content branch from 49a8ba7 to cbceb2e Compare June 5, 2024 21:11
@ChrisChV ChrisChV changed the title feat: Add content drawer in library home feat: Add content sidebar in library home Jun 6, 2024
@ChrisChV ChrisChV force-pushed the chris/FAL-3754-library-home-create-content branch from cbceb2e to a6b5df4 Compare June 7, 2024 16:27
@ChrisChV ChrisChV changed the title feat: Add content sidebar in library home [FC-0059] feat: Add content sidebar in library home Jun 26, 2024
@ChrisChV ChrisChV force-pushed the chris/FAL-3754-library-home-create-content branch from a298644 to 0ffbf82 Compare July 11, 2024 10:10
ChrisChV added 2 commits July 11, 2024 13:17
@ChrisChV ChrisChV force-pushed the chris/FAL-3754-library-home-create-content branch from cb93687 to 3c16ddf Compare July 11, 2024 11:49
@bradenmacdonald bradenmacdonald added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Jul 11, 2024
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice. This is almost there.

src/generic/toast-context/index.tsx Outdated Show resolved Hide resolved
src/generic/toast-context/index.tsx Outdated Show resolved Hide resolved
src/library-authoring/common/context.tsx Outdated Show resolved Hide resolved
src/library-authoring/common/context.tsx Outdated Show resolved Hide resolved
src/library-authoring/common/context.tsx Outdated Show resolved Hide resolved
src/library-authoring/common/context.tsx Outdated Show resolved Hide resolved
@ChrisChV
Copy link
Contributor Author

@bradenmacdonald It's ready for another review

@bradenmacdonald bradenmacdonald merged commit 3d24741 into openedx:master Jul 17, 2024
7 checks passed
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants