Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add to collection menu item functionality [FC-0062] #1413

Merged
merged 8 commits into from
Oct 22, 2024
Merged

feat: add to collection menu item functionality [FC-0062] #1413

merged 8 commits into from
Oct 22, 2024

Commits on Oct 22, 2024

  1. refactor: library context to accept sidebar component info 

    Replace three separate state variables with single object type
    @navinkarkera
    navinkarkera committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1695546 View commit details
    Browse the repository at this point in the history

  2. feat: show manage collections section in sidebar on menu click 

    Clicking on `Add to collection` menu item will display sidebar with
`Manage` tab open and `Tags` section collapsed for better visibility of
collections section.
    @navinkarkera
    navinkarkera committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ea9fdcb View commit details
    Browse the repository at this point in the history

  3. fix: lint issues

    @navinkarkera
    navinkarkera committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c1de5db View commit details
    Browse the repository at this point in the history

  4. test: try fix test that fail in CI 

    Possible issue: mockResult being modified by multiple tests in parallel
    @navinkarkera
    navinkarkera committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    724f107 View commit details
    Browse the repository at this point in the history

  5. refactor: use single action and open add to collection box

    @navinkarkera
    navinkarkera committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4eb7ecf View commit details
    Browse the repository at this point in the history

  6. fix: consistent add to collection menu action behaviour

    @navinkarkera
    navinkarkera committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8d3705f View commit details
    Browse the repository at this point in the history

  7. fix: lint issues

    @navinkarkera
    navinkarkera committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    00f0f48 View commit details
    Browse the repository at this point in the history

  8. chore: use sidebarComponent info in new component

    @navinkarkera
    navinkarkera committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    07567b3 View commit details
    Browse the repository at this point in the history