-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add to collection menu item functionality [FC-0062] #1413
feat: add to collection menu item functionality [FC-0062] #1413
Conversation
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
- Coverage 93.12% 93.11% -0.01%
==========================================
Files 1051 1051
Lines 20171 20207 +36
Branches 4207 4297 +90
==========================================
+ Hits 18784 18816 +32
- Misses 1327 1328 +1
- Partials 60 63 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -61,35 +74,57 @@ const ComponentManagement = () => { | |||
/> | |||
{[true, 'true'].includes(getConfig().ENABLE_TAGGING_TAXONOMY_PAGES) | |||
&& ( | |||
<Collapsible | |||
defaultOpen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it not possible to simply set defaultOpen={sidebarComponentInfo?.collapse !== 'tags'}
? That would be a lot simpler than making the collapsible into a controlled component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it only works when the component is first mounted.
Also looks like there is a conflict now. |
Replace three separate state variables with single object type
Clicking on `Add to collection` menu item will display sidebar with `Manage` tab open and `Tags` section collapsed for better visibility of collections section.
Possible issue: mockResult being modified by multiple tests in parallel
efdd2cd
to
00f0f48
Compare
@bradenmacdonald Done. Had to play with some |
@navinkarkera Nice! Seems to work well. Normally significant usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this, including testing it with the keyboard, and didn't find any remaining issues.
Description
Clicking on
Add to collection
menu item will display sidebar withManage
tab open andTags
section collapsed for better visibility of collections section. Also, refactors library context to replace three separate state variables with single object typeSupporting information
Private-ref
: FAL-3848Testing instructions
Add to Collection
menu item in components card as well as in the sidebar, it should open up sidebar with Manage tab active and tags section collapsed.gg