feat: create unit on libraries workflow [FC-0083]#1741
feat: create unit on libraries workflow [FC-0083]#1741ChrisChV merged 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
48c7495 to
6509ba5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1741 +/- ##
==========================================
+ Coverage 93.51% 93.52% +0.01%
==========================================
Files 1114 1117 +3
Lines 22532 22577 +45
Branches 4779 4783 +4
==========================================
+ Hits 21070 21115 +45
Misses 1397 1397
Partials 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aeb6355 to
6b445e2
Compare
| Question, | ||
| VideoCamera, | ||
| ContentPaste, | ||
| KeyboardBackspace, |
There was a problem hiding this comment.
Icons centralized on src/generic/block-type-utils/constants.ts
navinkarkera
left a comment
There was a problem hiding this comment.
@rpenido Works nicely! Left some small suggestions.
👍
- I tested this: (Created new units.)
- I read through the code
- I checked for accessibility issues
- Includes documentation
9a65d6c to
cb88135
Compare
8397cc7 to
9868784
Compare
ChrisChV
left a comment
There was a problem hiding this comment.
Looks good. Some nits on the tests 👍
b4b7d57 to
89a202d
Compare
Description
This PR implements the basic workflow to create a Unit in a Library.
Supporting information
Testing instructions
Note: The card view for the Unit has not been implemented yet, so interacting with this new Unit card will raise many errors as it is being handled as an ordinary Library Component.
Private ref: FAL-4056