Skip to content

feat: create unit on libraries workflow [FC-0083]#1741

Merged
ChrisChV merged 1 commit intoopenedx:masterfrom
open-craft:rpenido/fal-4056/create-unit-workflow
Mar 28, 2025
Merged

feat: create unit on libraries workflow [FC-0083]#1741
ChrisChV merged 1 commit intoopenedx:masterfrom
open-craft:rpenido/fal-4056/create-unit-workflow

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Mar 14, 2025

Description

This PR implements the basic workflow to create a Unit in a Library.

image

Supporting information

Testing instructions

  1. Make sure you are using this PR with Basic CRUD REST Endpoints for units in content libraries [FC-0083] openedx-platform#36371
  2. Open a library
  3. Click on the "+ New" button on the Library Header
  4. Select "Unit"
  5. . You should see the new Unit in the component list

Note: The card view for the Unit has not been implemented yet, so interacting with this new Unit card will raise many errors as it is being handled as an ordinary Library Component.


Private ref: FAL-4056

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 14, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 14, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 14, 2025
@rpenido rpenido changed the title feat: wip feat: create unit on libraries Mar 14, 2025
@rpenido rpenido changed the title feat: create unit on libraries feat: create unit on libraries workflow [FC-00083] Mar 14, 2025
@rpenido rpenido force-pushed the rpenido/fal-4056/create-unit-workflow branch 5 times, most recently from 48c7495 to 6509ba5 Compare March 14, 2025 19:05
@rpenido rpenido changed the title feat: create unit on libraries workflow [FC-00083] feat: create unit on libraries workflow [FC-0083] Mar 14, 2025
@rpenido rpenido marked this pull request as draft March 14, 2025 19:10
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (d497bf2) to head (89a202d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
+ Coverage   93.51%   93.52%   +0.01%     
==========================================
  Files        1114     1117       +3     
  Lines       22532    22577      +45     
  Branches     4779     4783       +4     
==========================================
+ Hits        21070    21115      +45     
  Misses       1397     1397              
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Mar 17, 2025
@rpenido rpenido force-pushed the rpenido/fal-4056/create-unit-workflow branch 4 times, most recently from aeb6355 to 6b445e2 Compare March 17, 2025 20:01
@rpenido rpenido marked this pull request as ready for review March 17, 2025 20:25
Question,
VideoCamera,
ContentPaste,
KeyboardBackspace,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Works nicely! Left some small suggestions.

👍

  • I tested this: (Created new units.)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@rpenido rpenido force-pushed the rpenido/fal-4056/create-unit-workflow branch 6 times, most recently from 9a65d6c to cb88135 Compare March 19, 2025 15:18
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 19, 2025
@rpenido rpenido force-pushed the rpenido/fal-4056/create-unit-workflow branch 2 times, most recently from 8397cc7 to 9868784 Compare March 19, 2025 15:36
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some nits on the tests 👍

@rpenido rpenido force-pushed the rpenido/fal-4056/create-unit-workflow branch from b4b7d57 to 89a202d Compare March 28, 2025 18:06
@ChrisChV ChrisChV merged commit df7405e into openedx:master Mar 28, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Mar 28, 2025
@rpenido rpenido deleted the rpenido/fal-4056/create-unit-workflow branch March 29, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants