Skip to content

feat: unit cards in library [FC-0083]#1742

Merged
ChrisChV merged 2 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4054/unit-card-in-libraries
Mar 31, 2025
Merged

feat: unit cards in library [FC-0083]#1742
ChrisChV merged 2 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4054/unit-card-in-libraries

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Mar 14, 2025

Description

image
image

Supporting information

Testing instructions

1 - Open the library
2 - Create some libraries (check #1741)
3 - Check the rendered Unit Card


Private ref: FAL-4054

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 14, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 14, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 14, 2025
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Mar 17, 2025
@rpenido rpenido force-pushed the rpenido/fal-4054/unit-card-in-libraries branch 4 times, most recently from 653fe72 to ad88876 Compare March 18, 2025 22:30
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (df7405e) to head (efdb5e8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1742      +/-   ##
==========================================
+ Coverage   93.52%   93.53%   +0.01%     
==========================================
  Files        1117     1119       +2     
  Lines       22577    22620      +43     
  Branches     4874     4885      +11     
==========================================
+ Hits        21115    21158      +43     
  Misses       1389     1389              
  Partials       73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 19, 2025
@rpenido rpenido force-pushed the rpenido/fal-4054/unit-card-in-libraries branch 4 times, most recently from 63a17b0 to 25832b1 Compare March 19, 2025 23:54
@rpenido rpenido force-pushed the rpenido/fal-4054/unit-card-in-libraries branch from 25832b1 to 922dae2 Compare March 20, 2025 00:15
@rpenido rpenido force-pushed the rpenido/fal-4054/unit-card-in-libraries branch from a64efd7 to f72c04a Compare March 20, 2025 22:07
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Unit cards look great, thank you @rpenido ! And thank you for the refactoring and TSX conversions you did here too :)

  • I tested this using the PR test instructions
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate
  • Includes documentation
  • User-facing strings are extracted for translation

@rpenido rpenido force-pushed the rpenido/fal-4054/unit-card-in-libraries branch from f72c04a to 7c8f227 Compare March 28, 2025 15:27
@rpenido rpenido marked this pull request as ready for review March 29, 2025 16:05
@rpenido rpenido force-pushed the rpenido/fal-4054/unit-card-in-libraries branch from a863cf3 to e3dd0b4 Compare March 29, 2025 16:08
@rpenido rpenido force-pushed the rpenido/fal-4054/unit-card-in-libraries branch from e3dd0b4 to efdb5e8 Compare March 29, 2025 16:14
@ChrisChV
Copy link
Contributor

I will merge this on Monday morning

@ChrisChV ChrisChV merged commit 98ae74e into openedx:master Mar 31, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Mar 31, 2025
@rpenido rpenido deleted the rpenido/fal-4054/unit-card-in-libraries branch March 31, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants

Comments