feat: unit cards in library [FC-0083]#1742
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
653fe72 to
ad88876
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1742 +/- ##
==========================================
+ Coverage 93.52% 93.53% +0.01%
==========================================
Files 1117 1119 +2
Lines 22577 22620 +43
Branches 4874 4885 +11
==========================================
+ Hits 21115 21158 +43
Misses 1389 1389
Partials 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
63a17b0 to
25832b1
Compare
25832b1 to
922dae2
Compare
a64efd7 to
f72c04a
Compare
There was a problem hiding this comment.
👍 Unit cards look great, thank you @rpenido ! And thank you for the refactoring and TSX conversions you did here too :)
- I tested this using the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
- User-facing strings are extracted for translation
f72c04a to
7c8f227
Compare
a863cf3 to
e3dd0b4
Compare
e3dd0b4 to
efdb5e8
Compare
|
I will merge this on Monday morning |
Description
Supporting information
Testing instructions
1 - Open the library
2 - Create some libraries (check #1741)
3 - Check the rendered Unit Card
Private ref: FAL-4054