feat: library units tab [FC-0083]#1754
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
ddcaf58 to
9faff28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1754 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 1119 1119
Lines 22620 22627 +7
Branches 4885 4796 -89
=======================================
+ Hits 21158 21165 +7
- Misses 1389 1397 +8
+ Partials 73 65 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a9547ea to
feecba3
Compare
b342c28 to
ccf1f35
Compare
pomegranited
left a comment
There was a problem hiding this comment.
Hi @rpenido , this looks and works great :) I found one weird filter issue, and left a test request, but will approve once these are addressed.
pomegranited
left a comment
There was a problem hiding this comment.
👍 Works great, thanks @rpenido !
- I tested this using the PR test instructions, and played with the various filters.
- I read through the code in open-craft#81
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
- User-facing strings are extracted for translation
|
Looks good! I will merge it when the other dependencies are merged |
d032c29 to
8326de7
Compare
8326de7 to
059a66e
Compare
059a66e to
2721883
Compare
Description
This PR implements the "Units" tab on the Library Authoring.
Supporting information
Testing instructions
Private ref:
FAL-4055